1498164 - Add parser support for multiple stores

Status: RESOLVED FIXED

(Toolkit :: Telemetry, enhancement, P1)

Description

[Jan-Erik Rediger [:janerik]]

All probes gain a new attribute `record_in_store`, defaulting to ['main'].
The parsers need to support that.

Code generation needs to generate the list of stores per probe.

Comment 1

[Jan-Erik Rediger [:janerik]]

Attachment: Bug 1498164 - Fix scalar definition in parser test

Previously the test succeeded, but not for the right reasons.

Comment 2

[Jan-Erik Rediger [:janerik]]

Attachment: Bug 1498164 - Use correct attribute to set release collection on dynamic scalar

Depends on D10918

Comment 3

[Jan-Erik Rediger [:janerik]]

Attachment: Bug 1498164 - Add support to parse `record_into_store` for scalars and histograms

Depends on D10919

Comment 4

[Jan-Erik Rediger [:janerik]]

Attachment: Bug 1498164 - Generate stores for scalars

This generates new things:

* store_count and store_offset in the ScalarInfo struct.
  store_count indicates the number of stores the scalar is registered in.
  store_offset is an offset into the gScalarStoresTable array.
  If store_count == 1 && store_offset == UINT16_MAX, then the scalar is only in the main store.
* gScalarStoresMap: An array containing the offsets into gScalarsStringTable to get a store's name

Depends on D10920

Comment 5

[Jan-Erik Rediger [:janerik]]

Attachment: Bug 1498164 - Generate stores for histograms

This generates several new things:

* store_count and store_offset in the HistogramInfo struct.
  store_count indicates the number of stores the histogram is registered in.
  store_offset is an offset into the gHistogramStoresTable array.
  If store_count == 1 && store_offset == UINT16_MAX, then the histogram is only in the main store.
* gHistogramStoresTable: An array containing the actual offsets into gHistogramStringTable to get a store's name

Depends on D10921

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/29641f93f289
Fix scalar definition in parser test r=chutten
https://hg.mozilla.org/integration/autoland/rev/d94fdea046be
Use correct attribute to set release collection on dynamic scalar r=chutten
https://hg.mozilla.org/integration/autoland/rev/feba93f1cc21
Add support to parse `record_into_store` for scalars and histograms r=chutten
https://hg.mozilla.org/integration/autoland/rev/b7563042430d
Generate stores for scalars r=chutten
https://hg.mozilla.org/integration/autoland/rev/4407a6d3e374
Generate stores for histograms r=chutten

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/29641f93f289
https://hg.mozilla.org/mozilla-central/rev/d94fdea046be
https://hg.mozilla.org/mozilla-central/rev/feba93f1cc21
https://hg.mozilla.org/mozilla-central/rev/b7563042430d
https://hg.mozilla.org/mozilla-central/rev/4407a6d3e374