Closed Bug 1498173 Opened 6 years ago Closed 5 years ago

Implement snapshotting from multiple stores for histograms

Categories

(Toolkit :: Telemetry, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: janerik, Assigned: janerik)

References

Details

Attachments

(4 files)

Once we record into multiple stores for histograms, we need to allow snapshotting from specified stores.
Priority: -- → P3
Priority: P3 → P1
Assignee: nobody → jrediger
This changes the API of the object returned from `Telemetry.getHistogramById`

* `add` will continue to record into all registered stores for the histogram.
* `snapshot` now takes an object `{store: "storeName"}`, if not given it defaults to "main"
* `clear` now takes an object `{store: "storeName"}`, if not given it defaults to "main"
BREAKING CHANGE:

    This changes the API of the object returned from `Telemetry.getKeyedHistogramById`.

    * `add` will continue to record into all registered stores for the histogram.
    * `snapshot` now takes an object `{store: "storeName"}`, if not given it defaults to "main".
      Support for getting a snapshot for just one key is dropped.
    * `keys` now takes an object `{store: "storeName"}`, if not given it defaults to "main"
    * `clear` now takes an object `{store: "storeName"}`, if not given it defaults to "main"

Depends on D12555
Pushed by jrediger@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5edb94ce0260
Allow snapshotting from non-main stores for plain histograms r=chutten
https://hg.mozilla.org/integration/autoland/rev/cf109d30e7ef
Allow snapshotting from non-main stores for keyed histograms r=chutten
https://hg.mozilla.org/integration/autoland/rev/5ff9933f5b59
Migrate internal tests to changed histogram API r=chutten
https://hg.mozilla.org/integration/autoland/rev/745309a6ca85
Migrate external tests to changed histogram API r=chutten
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: