Local Talos profiling on macOS doesn't symbolicate XUL

RESOLVED FIXED in Firefox 64

Status

enhancement
RESOLVED FIXED
8 months ago
7 months ago

People

(Reporter: mstange, Assigned: mstange)

Tracking

Trunk
mozilla64
All
macOS
Points:
---

Firefox Tracking Flags

(firefox64 fixed)

Details

Attachments

(1 attachment)

If you don't run mach buildsymbols and don't pass a symbols zip filename to "mach talos-test", Talos runs dump_syms_mac on any binaries that it doesn't have symbols for. This means that you shouldn't need to run "mach buildsymbols" on macOS and we'll get all the symbols anyways.
However, at the moment, dump_syms_mac aborts with an error when running on current versions of XUL:

"the section '__thread_bss' in segment '__DATA' claims its contents lie outside the segment's contents"

The current binary at testing/talos/talos/profiler/dump_syms_mac is one that I copied from my local object directory in 2014 or 2015; the build process creates it at objdir/dist/host/bin/dump_syms. Importing a newer version of that binary seems to fix the error.
Posted patch patchSplinter Review
Attachment #9016442 - Flags: review?(jmaher)
Attachment #9016442 - Flags: feedback?
Comment on attachment 9016442 [details] [diff] [review]
patch

Matt, can you check whether this patch fixes the problem for you?
Attachment #9016442 - Flags: feedback? → feedback?(matt.woodrow)
Comment on attachment 9016442 [details] [diff] [review]
patch

Review of attachment 9016442 [details] [diff] [review]:
-----------------------------------------------------------------

as this is just a binary file update, I am fine with that
Attachment #9016442 - Flags: review?(jmaher) → review+
It does! Symbols are mangled though, unsure if that's related or not.
Attachment #9016442 - Flags: feedback?(matt.woodrow) → feedback+

Comment 5

7 months ago
Pushed by mstange@themasta.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f8d848fba55e
Replace the dump_syms_mac binary in Talos with one that's able to parse our current XUL binaries. r=jmaher DONTBUILD

Comment 6

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f8d848fba55e
Status: ASSIGNED → RESOLVED
Last Resolved: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.