Closed
Bug 1498375
Opened 6 years ago
Closed 6 years ago
Content Search UI relies on old Gecko's <button> event hit testing
Categories
(Firefox :: Search, defect)
Firefox
Search
Tracking
()
RESOLVED
FIXED
Firefox 64
| Tracking | Status | |
|---|---|---|
| firefox64 | --- | fixed |
People
(Reporter: smaug, Assigned: smaug)
References
Details
Attachments
(1 file)
|
900 bytes,
patch
|
Gijs
:
review+
|
Details | Diff | Splinter Review |
The fix is to just make <button>'s child elements pointer-events: none;
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → bugs
|
|
Assignee | |
Comment 1•6 years ago
|
||
bug 1089326 makes us dispatch events also to contents of <button>.
Attachment #9016592 -
Flags: review?(gijskruitbosch+bugs)
|
||
Comment 2•6 years ago
|
||
Comment on attachment 9016592 [details] [diff] [review] content_search_ui_button.diff Review of attachment 9016592 [details] [diff] [review]: ----------------------------------------------------------------- Hrmpf. r=me, though really, maybe this should be using <input type=image> instead. Anyway, that's a separate fix.
Attachment #9016592 -
Flags: review?(gijskruitbosch+bugs) → review+
Pushed by opettay@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/05e256e81d2b Content Search UI relies on old Gecko's <button> event hit testing, r=gijs
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/05e256e81d2b
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
You need to log in
before you can comment on or make changes to this bug.
Description
•