Content Search UI relies on old Gecko's <button> event hit testing

RESOLVED FIXED in Firefox 64

Status

()

defect
RESOLVED FIXED
7 months ago
7 months ago

People

(Reporter: smaug, Assigned: smaug)

Tracking

unspecified
Firefox 64
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox64 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

7 months ago
The fix is to just make <button>'s child elements pointer-events: none;
Assignee

Updated

7 months ago
Assignee: nobody → bugs
Assignee

Comment 1

7 months ago
bug 1089326 makes us dispatch events also to contents of <button>.
Attachment #9016592 - Flags: review?(gijskruitbosch+bugs)

Comment 2

7 months ago
Comment on attachment 9016592 [details] [diff] [review]
content_search_ui_button.diff

Review of attachment 9016592 [details] [diff] [review]:
-----------------------------------------------------------------

Hrmpf. r=me, though really, maybe this should be using <input type=image> instead. Anyway, that's a separate fix.
Attachment #9016592 - Flags: review?(gijskruitbosch+bugs) → review+

Comment 3

7 months ago
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/05e256e81d2b
Content Search UI relies on old Gecko's <button> event hit testing, r=gijs

Comment 4

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/05e256e81d2b
Status: NEW → RESOLVED
Last Resolved: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
You need to log in before you can comment on or make changes to this bug.