Closed Bug 1498375 Opened 2 years ago Closed 2 years ago

Content Search UI relies on old Gecko's <button> event hit testing

Categories

(Firefox :: Search, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 64
Tracking Status
firefox64 --- fixed

People

(Reporter: smaug, Assigned: smaug)

References

Details

Attachments

(1 file)

The fix is to just make <button>'s child elements pointer-events: none;
Assignee: nobody → bugs
bug 1089326 makes us dispatch events also to contents of <button>.
Attachment #9016592 - Flags: review?(gijskruitbosch+bugs)
Comment on attachment 9016592 [details] [diff] [review]
content_search_ui_button.diff

Review of attachment 9016592 [details] [diff] [review]:
-----------------------------------------------------------------

Hrmpf. r=me, though really, maybe this should be using <input type=image> instead. Anyway, that's a separate fix.
Attachment #9016592 - Flags: review?(gijskruitbosch+bugs) → review+
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/05e256e81d2b
Content Search UI relies on old Gecko's <button> event hit testing, r=gijs
https://hg.mozilla.org/mozilla-central/rev/05e256e81d2b
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
You need to log in before you can comment on or make changes to this bug.