1498406 - Streamline Android configure post Gradle

Status: RESOLVED FIXED

(Firefox Build System :: Android Studio and Gradle Integration, enhancement)

Description

[Nick Alexander :nalexander [he/him]]

The Android build landscape has totally changed now that we always use Gradle to build.  We no longer invoke:
- javac
- javah
- jar
at all: all compilation and packaging is handled by Gradle and its plugins, and those plugins are fetched dynamically.  We no longer require a particular Android platform, nor a particular version of the Android build-tools, for the same reasons -- they are all fetched dynamically.

This should all mean that we can simplify https://searchfox.org/mozilla-central/source/build/autoconf/android.m4 radically.

Comment 1

[Nick Alexander :nalexander [he/him]]

Attachment: Bug 1498406 - Part 1: Don't check for javac, javah, jar.

The build system no longer invokes these directly: they're all fetched
and invoked by Gradle and its plugins.

Comment 2

[Nick Alexander :nalexander [he/him]]

Attachment: Bug 1498406 - Part 2: Don't check for Android platform in configure.

There's no need -- it will be fetched by Gradle when needed.  The only
wrinkle is that the user might be asked to confirm license agreements,
which could be a hassle (and could cause problems in CI, but there we
install relevant platforms in advance).

Depends on D14287

Comment 3

[Nick Alexander :nalexander [he/him]]

Attachment: Bug 1498406 - Part 3: Purge unused EMULATOR substitution. r?gbrown

Nothing is actually using the value of EMULATOR from the build system.

Depends on D14288

Comment 4

[Nick Alexander :nalexander [he/him]]

Attachment: Bug 1498406 - Part 3: Purge unused ANDROID_BUILD_TOOLS_VERSION.

We don't care anymore: the Gradle build fetches an appropriate version
of the build-tools package, and the one build-tool we actually use --
zipalign -- isn't version sensitive.

Depends on D14289

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/df01499f9fdf
Part 1: Don't check for javac, javah, jar. r=froydnj
https://hg.mozilla.org/integration/autoland/rev/cc64661d5c94
Part 2: Don't check for Android platform in configure. r=froydnj
https://hg.mozilla.org/integration/autoland/rev/b0002d2ea03f
Part 3: Purge unused ANDROID_BUILD_TOOLS_VERSION. r=froydnj

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/df01499f9fdf
https://hg.mozilla.org/mozilla-central/rev/cc64661d5c94
https://hg.mozilla.org/mozilla-central/rev/b0002d2ea03f