Closed Bug 1498464 Opened Last year Closed Last year

Random cleanup around BytecodeEmitter

Categories

(Core :: JavaScript Engine, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: arai, Assigned: arai)

Details

Attachments

(2 files)

No description provided.
Fixed obsolete comment in CallOrNewEmitter usage (emitNameCallee receives name atom)
Attachment #9016536 - Flags: review?(jorendorff)
Changed some parameter type from ParseNode* to subclasses, and also fixed some parameter name more descriptive.
Attachment #9016537 - Flags: review?(jorendorff)
Attachment #9016536 - Flags: review?(jorendorff) → review+
Comment on attachment 9016537 [details] [diff] [review]
Part 2: Fix BytecodeEmitter parameter type and name.

Review of attachment 9016537 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks again!

::: js/src/frontend/BytecodeEmitter.h
@@ +761,5 @@
>  
>      MOZ_MUST_USE bool emitConditionalExpression(ConditionalExpression& conditional,
>                                                  ValueUsage valueUsage = ValueUsage::WantValue);
>  
> +    bool isRestParameter(ParseNode* maybeRest);

Remember to rename this argument to whatever you chose in bug 1493870, instead of `maybeRest`.
Attachment #9016537 - Flags: review?(jorendorff) → review+
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0ece655d6f5b
Part 1: Fix comment for CallOrNewEmitter. r=jorendorff
https://hg.mozilla.org/integration/mozilla-inbound/rev/f503c7ea8126
Part 2: Fix BytecodeEmitter parameter type and name. r=jorendorff
https://hg.mozilla.org/mozilla-central/rev/0ece655d6f5b
https://hg.mozilla.org/mozilla-central/rev/f503c7ea8126
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.