[remote-dbg-next] Wait until ADB has started to show "USB enabled" message in Sidebar

RESOLVED FIXED in Firefox 68

Status

enhancement
P1
normal
RESOLVED FIXED
8 months ago
a month ago

People

(Reporter: jdescottes, Assigned: ladybenko)

Tracking

(Blocks 1 bug)

unspecified
Firefox 68
Dependency tree / graph

Firefox Tracking Flags

(firefox68 fixed)

Details

(Whiteboard: [remote-debugging-reserve])

Attachments

(2 attachments)

Reporter

Description

8 months ago
In Bug 1494549, we start showing a message when the ADB Addon is installed "ADB Devices enabled". 

However, after installing the addon, the addon-aware-adb-scanner automatically starts and will attempt to start ADB (devtools/shared/adb/abd.js). Starting ADB is async as it involves reading and unpacking the files from the addon. It might also fail for various reasons. We should also take this into account to decide to display the message. 

Some options here:

1/ listen to the "adb-ready" event emitted by ADB in aboutdebugging.js and check ADB.isReady when deciding to show the message

2/ same as 1/ but extracted in a module

3/ modify the scanner to expose a clearer status

I would tend to do 1 or 2 for now. I think in the future, the connect page will need to show if ADB failed to start, and propose to users to restart the scanner if it happened. So we will need to do 3/ ultimately, but it's better to wait until we know what kind of API we will need rather than implementing blindly now.
Reporter

Updated

7 months ago
Assignee

Updated

2 months ago
Assignee: nobody → balbeza
Status: NEW → ASSIGNED
Priority: P3 → P1
Whiteboard: [remote-debugging-reserve]

Comment 3

a month ago
Pushed by balbeza@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/913c397010c2
Part 1: Wait until adb process is ready to show the 'Usb enabled' message r=jdescottes,daisuke
https://hg.mozilla.org/integration/autoland/rev/512231282d5f
Part 2: Add test for the feature r=jdescottes,daisuke

Comment 4

a month ago
bugherder
Status: ASSIGNED → RESOLVED
Last Resolved: a month ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
You need to log in before you can comment on or make changes to this bug.