Closed
Bug 1498483
Opened 6 years ago
Closed 6 years ago
File > Save As > File - doesn't overwrite existing file when replace was chosen
Categories
(Thunderbird :: Message Compose Window, defect)
Tracking
(thunderbird_esr6063+ fixed, thunderbird63 wontfix, thunderbird64 fixed)
RESOLVED
FIXED
Thunderbird 64.0
People
(Reporter: marcoagpinto, Assigned: jorgk-bmo)
Details
Attachments
(1 file)
|
1.16 KB,
patch
|
aceman
:
review+
jorgk-bmo
:
approval-comm-beta+
jorgk-bmo
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
Hello! When I am composing a message and I drag and drop an image (tested with PNGs) into it, if I select: File > Save As > File, and the file untitled.html already exists, it asks if we want to overwrite it, I select yes, but it ignores the "yes" and keeps the old file. Try doing this multiple times. It will always keep the old untitled.html .
|
Assignee | |
Comment 1•6 years ago
|
||
Confirmed :-( - You don't need an image, just make something bold in the text so that it's saved as untitled.html. Actually, if you just enter unformatted text, the file untitled.txt isn't overwritten. Alice, can you find the regression for us? It might be bug 1341211, especially https://hg.mozilla.org/comm-central/rev/36bd1eaceefb
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(alice0775)
|
||
Comment 2•6 years ago
|
||
Regression window: https://hg.mozilla.org/comm-central/pushloghtml?fromchange=13e8fa67e60a3180c22702527f6f1079f290ce90&tochange=46e8d4d1250d6196106c5bcf875eb0398fa59cec https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=32083f24a1bb2c33050b4c972783f066432194eb&tochange=fe6609d22dfdd710b11e3ac7773aff89f7a8d12c
Flags: needinfo?(alice0775)
|
|
Assignee | |
Updated•6 years ago
|
Summary: File > Save As > File - doesn't overwrite html files → File > Save As > File - doesn't overwrite existing file when replace was chosen
|
|
Assignee | |
Comment 3•6 years ago
|
||
Regression is here: https://hg.mozilla.org/comm-central/rev/d361db344198#l1.13 Thanks, Alice!!!
|
|
Assignee | |
Comment 4•6 years ago
|
||
Marco, thanks for reporting. We'll get it fixed in TB 60.3 in 10 days.
Comment on attachment 9016967 [details] [diff] [review] 1498483-allow-overwrite.patch Review of attachment 9016967 [details] [diff] [review]: ----------------------------------------------------------------- Thanks, works for me.
Attachment #9016967 -
Flags: review?(acelists) → review+
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/2df9fd956bec saving current composition doesn't overwrite existing file. r=aceman
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•6 years ago
|
Target Milestone: --- → Thunderbird 64.0
|
|
Assignee | |
Updated•6 years ago
|
Attachment #9016967 -
Flags: approval-comm-esr60+
Attachment #9016967 -
Flags: approval-comm-beta+
|
|
Assignee | |
Comment 7•6 years ago
|
||
TB 60.3 ESR: https://hg.mozilla.org/releases/comm-esr60/rev/445acd6b34fe
status-thunderbird63:
--- → affected
status-thunderbird64:
--- → fixed
status-thunderbird_esr60:
--- → fixed
tracking-thunderbird_esr60:
--- → 63+
|
|
Assignee | |
Comment 8•6 years ago
|
||
TB 63.0b2: https://hg.mozilla.org/releases/comm-beta/rev/08e9d13eafee
|
|
Assignee | |
Updated•6 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•