Update TBDistCustomizer.jsm to match Firefox version; stop using eval

RESOLVED FIXED in Thunderbird 66.0

Status

enhancement
RESOLVED FIXED
6 months ago
3 months ago

People

(Reporter: darktrojan, Assigned: aceman)

Tracking

unspecified
Thunderbird 66.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 months ago
mail/base/modules/TBDistCustomizer.jsm is our equivalent of browser/components/distribution.js

Bug 1251729 removed the use of eval from distribution.js. We should do the same, because eval is bad.

There might be other fixes we can take too.
(Reporter)

Comment 1

6 months ago
And mail/base/test/unit/test_mailGlue_distribution.js, while we're at it.
(Assignee)

Comment 2

3 months ago
Posted patch 1498497.patchSplinter Review

I put the parseValue() inside of TBDistCustomizer so it can be called from the test. That differs slightly from the Firefox version.

Assignee: nobody → acelists
Status: NEW → ASSIGNED
Attachment #9038926 - Flags: review?(jorgk)

Comment 3

3 months ago
Comment on attachment 9038926 [details] [diff] [review]
1498497.patch

Looks good comparing to the M-C code.
Attachment #9038926 - Flags: review?(jorgk) → review+

Updated

3 months ago
Keywords: checkin-needed

Comment 4

3 months ago

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/0a405faf8b1d
Stop using eval in TBDistCustomizer.jsm to match Firefox. r=jorgk

Status: ASSIGNED → RESOLVED
Last Resolved: 3 months ago
Keywords: checkin-needed
Resolution: --- → FIXED

Updated

3 months ago
Target Milestone: --- → Thunderbird 66.0
You need to log in before you can comment on or make changes to this bug.