Closed Bug 1498531 Opened 3 years ago Closed 3 years ago
RR console "Jump" icon could be better
46 bytes, text/x-phabricator-request
|Details | Review|
In Bug 1496468, a "Jump" button was added when a recording was done by the user. This is great but the button could be a bit better: - It should be l10n'd, and have a similar label to the one we are using in the context menu. - It hides the "level" icon (error, warning, …) to only show the jump icon when the message is hovered. We should keep the level icon, and only show the jump icon when the user hover the message. - The button is styled via its `title` attribute in CSS, which isn't ideal and is error prone (title might - and will, with l10n - change in the future. A dedicated class would be better.
This patch adds localization for the WebReplay Jump icon, and uses the same terminology as the one used in the context menu that triggers the same action. The Jump button was used in-place of the existing level icons (Error, Warning, …), and was only displayed when the message was hovered. The patch now ensure the level icon is always visible and that we only show the Jump icon when the message is hovered. Finally, the button was styled targetting the title attribute in CSS, which seemed a little brittle. We now use a dedicated class which should be safer and more future proof.
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/aa628ce24d80 Localize Webconsole WebReplay Jump icon; r=loganfsmyth,Honza.
You need to log in before you can comment on or make changes to this bug.