1498598 - Autocomplete popup should not be displayed after `var `, `let ` or `const `

Status: RESOLVED FIXED

(DevTools :: Console, defect, P1)

Description

[Nicolas Chevobbe [:nchevobbe]]

**Steps to reproduce**
1. Open the console
2. Type `var w`

**Actual results**

The autocomplete popup opens, but since I want to define a new variable it gets into my way.

---

We should simply not show the autocomplete when the user wants to define a variable.
I guess this could be extended to `function `, `class ` and I'm sure other I'm forgetting when it does not make sense to show the popup.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1498598 - Make js-property-provider better; r=bgrins.

This patches solves 2 issues:
- it doesn't return any result when the user is trying to
perform a variable, function or class declaration (e.g.
var d).
- js-property-provider used to compute the last statement
by only looking for space or ; chars. But there are a lot
of cases (basically each time using an operator), where we
should return results and we weren't.
Test cases are added to cover those fixes.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a8e1eaf6d370
Make js-property-provider better; r=bgrins.

Comment 3

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/a8e1eaf6d370