Closed Bug 1498625 Opened 1 year ago Closed 1 year ago

Start/Stop HapticThread of OpenVRSession in the main thread.

Categories

(Core :: WebVR, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: daoshengmu, Assigned: daoshengmu)

References

Details

Attachments

(2 files)

When dom.vr.process;true, the HapticThread would hit an assertion about creating a threads. We need move this create/shutdown thread behaviors to the main thread.
Blocks: 1362578
Make `dom.vr.process;true, dom.vr.external.enabled;true` to test it in VR process with Windows.
Assignee: nobody → dmu
I notice VR process's main thread will idle tasks when calling NS_DispatchToMainThread(). I have to change the current message_loop type of VR process to MOZILLA_CHILD as what GPU process did.
(In reply to Daosheng Mu[:daoshengmu] from comment #3)
> Created attachment 9021981 [details]
> Bug 1498625 - Part 1: Move VRHapticThread start/end to the main thread.

:froydnj please help review the changes in VRParent.cpp for initializing the task manager.
Blocks: 1476092
Pushed by dmu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/604c2334df1d
Part 1: Move VRHapticThread start/end to the main thread. r=kip,froydnj
https://hg.mozilla.org/integration/autoland/rev/65c79ddf98f0
Part 2: Switch VR process to TYPE_MOZILLA_CHILD message loop type. r=froydnj,handyman
https://hg.mozilla.org/mozilla-central/rev/604c2334df1d
https://hg.mozilla.org/mozilla-central/rev/65c79ddf98f0
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.