Use __gcov_flush instead of __gcov_dump and __gcov_reset

RESOLVED FIXED in Firefox 64

Status

enhancement
RESOLVED FIXED
10 months ago
10 months ago

People

(Reporter: marco, Assigned: marco)

Tracking

unspecified
mozilla64
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox64 fixed)

Details

Attachments

(1 attachment)

No description provided.
Posted patch PatchSplinter Review
Attachment #9017165 - Flags: review?(nfroyd)
Comment on attachment 9017165 [details] [diff] [review]
Patch

Review of attachment 9017165 [details] [diff] [review]:
-----------------------------------------------------------------

Nit: commit message should be "to implement".

::: tools/code-coverage/CodeCoverageHandler.cpp
@@ +31,2 @@
>  
>    CrossProcessMutexAutoLock lock(*CodeCoverageHandler::Get()->GetMutex());

Since __gcov_flush is protected by a mutex, per the previous version's code comment, do we need this CrossProcessMutex anymore?  If not, please file a followup to remove it.
Attachment #9017165 - Flags: review?(nfroyd) → review+
(In reply to Nathan Froyd [:froydnj] from comment #2)
> ::: tools/code-coverage/CodeCoverageHandler.cpp
> @@ +31,2 @@
> >  
> >    CrossProcessMutexAutoLock lock(*CodeCoverageHandler::Get()->GetMutex());
> 
> Since __gcov_flush is protected by a mutex, per the previous version's code
> comment, do we need this CrossProcessMutex anymore?  If not, please file a
> followup to remove it.

I've updated the comment, as it is protected in GCC but doesn't seem to be protected in LLVM.
Pushed by mcastelluccio@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5687061cc832
Use __gcov_flush to implement dumping and resetting instead of __gcov_dump and __gcov_reset. r=froydnj
https://hg.mozilla.org/mozilla-central/rev/5687061cc832
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.