Closed Bug 1498672 Opened Last year Closed Last year

Sandbox breaks on mingw-clang with template error

Categories

(Core :: Security: Process Sandboxing, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox-esr60 --- fixed
firefox64 --- fixed

People

(Reporter: tjr, Assigned: tjr)

References

Details

Attachments

(1 file)

> error: implicit instantiation of undefined template 'std::__1::basic_string<wchar_t, std::__1::char_traits<wchar_t>, std::__1::allocator<wchar_t> >'
> static const std::wstring ZONE_IDENTIFIER_STR(L":ZONE.IDENTIFIER");
>                          ^
> /home/tom/Documents/moz/mingw-tools/toolchains/mingwclang-x64/bin/../x86_64-w64-mingw32/include/c++/v1/iosfwd:193:32: note: template is declared here
>    class _LIBCPP_TEMPLATE_VIS basic_string;

We need to include string, which is often, but not always, included by algorithm. For the mingw-clang build it isn't and thus - it breaks.
Component: General: Unsupported Platforms → Security: Process Sandboxing
Product: Firefox Build System → Core
Attachment #9016760 - Flags: review?(bobowencode) → review+
Pushed by ccoroiu@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c0b3c3c948fd
Include string.h explicitly instead of relying on algorithm to bring it in r=bobowen
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/c0b3c3c948fd
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla64

Comment on attachment 9016760 [details] [diff] [review]
Bug 1498672 Include string.h explicitly instead of relying on algorithm to bring it in

[ESR Uplift Approval Request]

If this is not a sec:{high,crit} bug, please state case for ESR consideration: Needed to enable the sandbox on esr60

User impact if declined: Tor will have to carry another patch and we don't be able to enable the sandbox on esr60

Fix Landed on Version: 64.0a1 / 20181015223336

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): Just adds a header

String or UUID changes made by this patch:

Attachment #9016760 - Flags: approval-mozilla-esr60?

Comment on attachment 9016760 [details] [diff] [review]
Bug 1498672 Include string.h explicitly instead of relying on algorithm to bring it in

fix for mingwclang, approved for 60.5esr

Attachment #9016760 - Flags: approval-mozilla-esr60? → approval-mozilla-esr60+
You need to log in before you can comment on or make changes to this bug.