60 second pause instead of browser restart on Android

RESOLVED FIXED in Firefox 64

Status

enhancement
RESOLVED FIXED
10 months ago
10 months ago

People

(Reporter: gbrown, Assigned: gbrown)

Tracking

Version 3
mozilla64
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox64 fixed)

Details

Attachments

(1 attachment)

With recent changes we can run wpt on android. However instead of restarting the browser between groups of tests, I see a 60 second pause. What are we waiting for?

Running locally:

$ ./mach -v wpt testing/web-platform/tests/infrastructure/
...
 0:33.28 TEST_START: /infrastructure/assumptions/cookie.html
 0:33.38 TEST_END: Test OK. Subtests passed 1/1. Unexpected 0
 0:33.39 TEST_START: /infrastructure/assumptions/html-elements.html
 0:33.62 TEST_END: Test OK. Subtests passed 11/11. Unexpected 0
 0:33.62 TEST_START: /infrastructure/assumptions/non-secure-context.any.worker.html
 0:33.78 TEST_END: Test OK. Subtests passed 2/2. Unexpected 0
 0:33.78 TEST_START: /infrastructure/assumptions/non-secure-context.any.html
 0:33.93 TEST_END: Test OK. Subtests passed 2/2. Unexpected 0
 0:33.93 INFO Restarting browser for new test environment
 1:35.95 WARNING u'runner_teardown': ()
 1:35.95 INFO Closing logging queue
 1:35.95 INFO queue closed

Notice the 60+ second wait after "Restarting browser for new test environment".
Assignee: nobody → gbrown
This works great for me so far, but I'm still testing.
Now:

 0:29.33 TEST_END: Test OK. Subtests passed 2/2. Unexpected 0
 0:29.33 INFO Restarting browser for new test environment
 0:30.38 INFO Browser exited with return code 0
 0:30.38 WARNING u'runner_teardown': ()
 0:30.38 INFO Closing logging queue
 0:30.38 INFO queue closed
Attachment #9016767 - Flags: feedback+
Comment on attachment 9016767 [details] [diff] [review]
request browser stop before waiting

Haven't tested it yet myself, but this looks right to me.
Attachment #9016767 - Flags: review?(wkocher) → review+
Pushed by wkocher@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/54598c1940f1
Fix wpt runner's browser stop implementation: request stop before waiting; r=kwierso
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/13501 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
https://hg.mozilla.org/mozilla-central/rev/54598c1940f1
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Upstream PR merged
Can't merge web-platform-tests PR due to failing upstream checks:
Github PR https://github.com/web-platform-tests/wpt/pull/13501
* Taskcluster (pull_request) (https://tools.taskcluster.net/task-group-inspector/#/RL7NC741SiSYdYxjhC0Ltw)
Blocks: 1425322
You need to log in before you can comment on or make changes to this bug.