1498721 - Implement default methods for all delegate interfaces

Status: RESOLVED FIXED

(GeckoView :: General, enhancement, P3)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

Now that we're using Java 1.8, we should be able to provide default implementations for all delegate interface methods. This will make it a lot more convenient for app that only want to override a subset of the methods. It will also help our source API compatibility situation, since app code will still build if new methods are added to a delegate.

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Bug 1498721 - Add default methods to GeckoView delegate interfaces r?#geckoview-reviewers

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Bug 1498721 - Disable Java code coverage on Android r?gbrown

This is due to an incompatability somewhere between JaCoCo and
default interface methods.

Depends on D23016

Comment 3

[Marco Castelluccio [:marco]]

(In reply to James Willcox (:snorp) ([e-mail]) (he/him) from comment #2)

Created attachment 9050069 [details]
Bug 1498721 - Disable Java code coverage on Android r?gbrown

This is due to an incompatability somewhere between JaCoCo and
default interface methods.

Depends on D23016

It's a bug somewhere in the Android SDK rather than in JaCoCo.
I filed https://issuetracker.google.com/issues/128277032 for this (https://issuetracker.google.com/issues/109759777 was the same, but was closed right away with no investigation).

Comment 5

[James Willcox (:snorp) ([e-mail]) (he/him)]

The reporter for the JaCoCo bug (https://github.com/jacoco/jacoco/issues/690) reported that it worked with minSdkVersion 24, but that didn't seem to help for me.

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/3504d6975a6d
https://hg.mozilla.org/mozilla-central/rev/01aa96181b7b

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/integration/autoland/rev/3504d6975a6d345d89fd6dff5409d99a75115889
https://hg.mozilla.org/integration/autoland/rev/01aa96181b7b4cee86095a96e4f4d38d1b8a479a