1498758 - Update placeholder value of DNS over HTTPS input

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[Erica Wright [:ewright]]

+++ This bug was initially created as a clone of Bug #1495583 +++

This is to change the placeholder in the DNS over HTTPS preferences pane to the cloudflare url.
To provide the user with at least a hint of which url they can use if they change it. This will be temporary until https://bugzilla.mozilla.org/show_bug.cgi?id=1495583 can land.

Comment 1

[Erica Wright [:ewright]]

Attachment: bug 1498758 - Update placeholder value of DNS over HTTPS input, add default pref value

Update placeholder value of DNS over HTTPS input to the cloudflare provider add a default pref value for network.trr.uri

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b2dc8c549bc4
Update placeholder value of DNS over HTTPS input, add default pref value r=jduell

Comment 3

[Jason Duell]

My apologies for stepping in here to review this last-minute. We really want this for 63 so we don't provide a useless example URI for DNS-over-HTTPS. Confident that our CTO agrees with me (and I'm double-checking with him)

(The patch we originally were going to uplift--bug 1495583--turned out to need localization. This doesn't, and is simpler too.)

Comment 4

[Jason Duell]

Comment on attachment 9016883 [details]
bug 1498758 - Update placeholder value of DNS over HTTPS input, add default pref value

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: DNS-over-HTTPS preferences UX

User impact if declined: DNS-over-HTTPS is turned off in 63, but is available to enable in Preferences (General | Networking | enable DNS-over-HTTPS: I'll add a screenshot).  We're about to ship with a bogus 'example' URI as the default provider, which is Bad (it requires users to find and cut-and-paste a provider URI to get it working).   We want to instead default to the valid provider URI that we've already cut a business deal with to provide DNS-over-HTTPS for us.

Is this code covered by automated tests?: Yes

Has the fix been verified in Nightly?: No

Needs manual test from QE?: No

If yes, steps to reproduce: 

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): Only changes default URI in about:config, and in some UX code

String changes made/needed:

Comment 5

[Jason Duell]

To clarify comment 0: this patch also sets the trr.uri pref (i.e. it makes DNS-over-HTTPS work if a user enables it). So it's not just providing a suggestion.

Comment 6

[Jason Duell]

Attachment: bad: example.com (about to ship in 63)

Comment 7

[Jason Duell]

Attachment: good: with patch, uses cloudflare

Comment 8

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/b2dc8c549bc4

Comment 9

[Pascal Chevrel:pascalc]

Comment on attachment 9016883 [details]
bug 1498758 - Update placeholder value of DNS over HTTPS input, add default pref value

The patch is minimal has tests and is a clear UX improvement, I also verified that it works as intended on Nightly, let's take it before the merge.

Comment 10

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/releases/mozilla-beta/rev/f96837a1bcfc