Closed Bug 1498767 Opened 2 years ago Closed 2 years ago
Some MFBT tests don't run in automation
46 bytes, text/x-phabricator-request
|Details | Review|
Some of the C++ unit tests in mfbt/tests are not running in automation. To illustrate, I changed some tests to deliberately fail by adding a |MOZ_RELEASE_ASSERT(false)| to them, and pushed to Try: https://treeherder.mozilla.org/#/jobs?repo=try&tier=1&revision=66d812115762c9b469c0ee51477079c92d862471 and the Try push is green. After some spelunking in the log of the "Cpp" test job to see what command it calls (testing/runcppunittests.py), and what that command does, I discovered that the problem is that only those tests listed in testing/cppunittest.ini  are run, and not all MFBT tests are listed there.  https://searchfox.org/mozilla-central/source/testing/cppunittest.ini
Also add a comment to mfbt/tests/moz.build to remind people that tests need to be added to testing/cppunittest.py.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/b8d90d5901be Add missing MFBT tests to testing/cppunittest.py. r=froydnj
You need to log in before you can comment on or make changes to this bug.