Closed Bug 1498788 Opened 1 year ago Closed 1 year ago

Crash in mozilla::D3D11DXVA2Manager::CopyToImage

Categories

(Core :: Graphics: Layers, defect, critical)

Unspecified
Windows 10
defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox-esr60 --- unaffected
firefox62 --- unaffected
firefox63 --- unaffected
firefox64 --- fixed

People

(Reporter: calixte, Assigned: jya)

References

(Blocks 1 open bug)

Details

(Keywords: crash, regression)

Crash Data

Attachments

(1 file)

This bug was filed from the Socorro interface and is
report bp-e4fe81ff-eea1-4546-8ab0-1e02e0181012.
=============================================================

Top 10 frames of crashing thread:

0 xul.dll mozilla::D3D11DXVA2Manager::CopyToImage dom/media/platforms/wmf/DXVA2Manager.cpp:973
1 xul.dll HRESULT mozilla::WMFVideoMFTManager::CreateD3DVideoFrame dom/media/platforms/wmf/WMFVideoMFTManager.cpp:1044
2 xul.dll mozilla::WMFVideoMFTManager::Output dom/media/platforms/wmf/WMFVideoMFTManager.cpp:1198
3 xul.dll HRESULT mozilla::WMFMediaDataDecoder::ProcessOutput dom/media/platforms/wmf/WMFMediaDataDecoder.cpp:161
4 xul.dll class RefPtr<mozilla::MozPromise<nsTArray<RefPtr<mozilla::MediaData> >, mozilla::MediaResult, 1> > mozilla::WMFMediaDataDecoder::ProcessDecode dom/media/platforms/wmf/WMFMediaDataDecoder.cpp:149
5 xul.dll nsresult mozilla::detail::ProxyRunnable<mozilla::MozPromise<nsTArray<RefPtr<mozilla::MediaData> >, mozilla::MediaResult, 1>, RefPtr<mozilla::MozPromise<nsTArray<RefPtr<mozilla::MediaData> >, mozilla::MediaResult, 1> >  xpcom/threads/MozPromise.h:1401
6 xul.dll mozilla::TaskQueue::Runner::Run xpcom/threads/TaskQueue.cpp:235
7 xul.dll nsThreadPool::Run xpcom/threads/nsThreadPool.cpp:242
8 xul.dll nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1252
9 xul.dll NS_ProcessNextEvent xpcom/threads/nsThreadUtils.cpp:530

=============================================================

There is 1 crash in nightly 64 with buildid 20181012103207. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1497294.

[1] https://hg.mozilla.org/mozilla-central/rev?node=e62671b3410d
Flags: needinfo?(jyavenard)
Too bad they didn't provide a URL...

I wonder how that can happen (hence the assert)...

That would mean that the decoded image was actually shorter than what the H264 SPS indicates (assuming it's h264)

I'll add code to handle that.
Assignee: nobody → jyavenard
Flags: needinfo?(jyavenard)
Why we would need this is unclear however. the destination texture should always be smaller than what comes out of the decoder.
Pushed by jyavenard@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8bf31628742d
Adjust width and height so they are never bigger than source or destination. r=mattwoodrow
https://hg.mozilla.org/mozilla-central/rev/8bf31628742d
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
See Also: → 1497951
You need to log in before you can comment on or make changes to this bug.