Closed Bug 1498790 Opened Last year Closed Last year

Port bug 1496382 to TB: Don't use "groupbox" for Preferences subdialogs

Categories

(Thunderbird :: Preferences, task)

task
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 64.0

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file)

In bug 1429940 m-c is planning to remove the groupbox and caption. This is to be in synch with FX in the prefs/dialogs.
This is a port of https://hg.mozilla.org/mozilla-central/rev/80983dcd1180

In the XML file some elements where 2 spacees too much indented, fixed by this patch.

In the CSS file I changed the font size of .dialogTitle (the title in the dialog titlebar) to have the same size as before this patch. FX haven't changed it but this seems to give a smaller font size than they had before.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9016931 - Flags: review?(jorgk)
Another "spot the difference" review. Where are groupbox and caption used in subdialogues?
This patch (and the FX patch) exchanges only the groupbox in the dialog titlebar and the body of the dialogs, not the content. So you have only to check the dialog titlebar and that the content in it looks the same.
Comment on attachment 9016931 [details] [diff] [review]
1498790-dialogNoGroupbox.patch

I tried a few subdialogues for fonts and about:config, all worked. I noticed that the the titlebars are not as high, which is a good thing. The caption fonts maintained their size with the patch, but they are bigger than in TB 60.
Attachment #9016931 - Flags: review?(jorgk) → review+
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/d3153e99afae
Port bug 1496382 to TB: Don't use "groupbox" for Preferences subdialogs. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 64.0
Type: enhancement → task
You need to log in before you can comment on or make changes to this bug.