1498835 - Tier 3 is hard to select

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Frontend, defect)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Steps to reproduce:
1) Load https://treeherder.mozilla.org/#/jobs?repo=try&revision=955a7fd1a807357faa79336b16418c41541be24e
This is a try push with 36 or so tier-3 android web-platform-test jobs.
2) Open the Tiers menu.
3) Click "Tier 3" to show those tier 3 jobs. You'll see the checkbox get checked and immediately uncheck itself.
4) Click "Tier 3" again. This will have the filter bar (and the filters in the URL) show that tiers 1 and 2 are visible. The tier 3 checkbox will again get checked and immediately uncheck itself.
5) Click "Tier 3" again. This will finally check the tier 3 checkbox and it stays checked. The tier-3 android jobs will be shown. The tiers in the filter bar and the filters in the URL bar will disappear like we're back to the default tier selections, even though we aren't.
6) If you reload the page, we're back to the state we were in step 1.

This seems wrong to me.

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

On my phone, it only took two clicks on the "Tier 3" checkbox to get it to show the tier-3 jobs, but testing on desktop it takes three.

Comment 2

[Cameron Dawson [:camd]]

Whoa!  And the checkboxes for the other two tiers don't display for me, too.  Something's surely broken there.  Working on this now.

Comment 3

[Cameron Dawson [:camd]]

This is an interesting bug.  It seems like this must have been here since 9/4/2018 when I re-did the filterModel.  This was a case where I wasn't properly cloning the ``defaults`` object.  We use that object to set the default state of certain filters, but also to compare the current state to see if we should remove the filter param from the URL.  So we ended up modifying the original ``defaults`` object to which we compare to see if we are in the "default" state.  Not sure that makes sense, but doing a deepClone from ``lodash`` is a simple and safe solution.

Comment 4

[Cameron Dawson [:camd]]

The part where the "checked" boxes don't display is a nightly bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1498921.  So I'm just fixing the functional problem.

Comment 5

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/4141

Comment 6

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/a68479a017b38145a90701c9e4601f09c06beb2b
Bug 1498835 - Fix toggling tier-3 (#4141)