1498863 - Shutting down TB when preferences were open causes malfunction after restart, reopening options tab doesn't highlight selected pane

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect)

Description

[Jorg K (CEST = GMT+2)]

Shutting down TB when preferences were open in a tab makes pane selection unresponsive after restart.

STR:
Open preferences, select Display, Tags
Close TB
Start TB
Comes back with "General", no pane selected.
Try to switch pref pane.

Result: It doesn't work.

I've had cases where it came back with the Display pane, but General was selected. That's what it does when you select Display, Tags, then close the options tab and open it again.

Conclusion: Mileage varies, but it's buggy.

Tested with Calendar disabled.

Comment 1

[Jorg K (CEST = GMT+2)]

Tried this in official Daily of 2018-10-13, both are reproducible:
If you start with the Options tab open, pane selection doesn't work.
If you close options and re-open, the pane selection isn't right.

Comment 2

[Geoff Lankow (:darktrojan)]

This wouldn't involve a radiogroup, would it? (Spoiler: it does.) Broken by bug 1481949.

Comment 3

[Geoff Lankow (:darktrojan)]

Attachment: 1498863-pref-pane-select-1.diff

I don't quite know what the root cause is, but this fixes it.

Comment 4

[Jorg K (CEST = GMT+2)]

Comment on attachment 9017057 [details] [diff] [review]
1498863-pref-pane-select-1.diff

One line fixes this annoying bug, thanks. That broke a while ago and no one complained :-( - I'll ship it now.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/08a107c8c517
Fix broken remembering of selected preference pane after bug 1481949. r=jorgk DONTBUILD