Closed
Bug 1498898
Opened 5 years ago
Closed 5 years ago
Terminal warnings "Unknown widget type" when cursor passes over elements in toolbox
Categories
(Core :: Widget: Gtk, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla65
Tracking | Status | |
---|---|---|
firefox-esr60 | --- | unaffected |
firefox62 | --- | unaffected |
firefox63 | --- | unaffected |
firefox64 | --- | fixed |
firefox65 | --- | fixed |
People
(Reporter: ke5trel, Assigned: stransky)
References
(Blocks 1 open bug)
Details
(Keywords: regression)
Attachments
(1 file)
46 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
Since Bug 1498356, when the mouse cursor passes over different elements in the toolbox, the following warning appears repeatedly in the terminal: > ** (firefox:3240): WARNING **: 18:04:15.167: Unknown widget type: 95
Updated•5 years ago
|
status-firefox62:
--- → unaffected
status-firefox63:
--- → unaffected
Comment 1•5 years ago
|
||
I have the same problem with: 64.0a1 (2018-10-16) (64-bit) status-firefox64: --- → affected
Assignee | ||
Comment 3•5 years ago
|
||
That's because we introduced a MOZ_GTK_HEADER_BAR_BUTTON_BOX widget but we don't want to draw it. I'm thinking of the best way how to handle it.
Assignee | ||
Comment 5•5 years ago
|
||
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → stransky
![]() |
||
Updated•5 years ago
|
Priority: -- → P1
Assignee | ||
Updated•5 years ago
|
Keywords: checkin-needed
Pushed by ccoroiu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0a63507e990c Don't draw container-only widgets, r=jhorak
Keywords: checkin-needed
Comment 7•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/0a63507e990c
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
status-firefox-esr60:
--- → unaffected
Assignee | ||
Comment 8•5 years ago
|
||
Comment on attachment 9019012 [details] Bug 1498898 - Don't draw container-only widgets, r=jhorak [Beta/Release Uplift Approval Request] Feature/Bug causing the regression: Bug 1498356 User impact if declined: Error messages on command line when titlebar is disabled Is this code covered by automated tests?: No Has the fix been verified in Nightly?: Yes Needs manual test from QE?: No If yes, steps to reproduce: List of other uplifts needed: None Risk to taking this patch: Low Why is the change risky/not risky? (and alternatives if risky): Minor code change in theme rendering. String changes made/needed: none
Attachment #9019012 -
Flags: approval-mozilla-beta?
Comment 9•5 years ago
|
||
Comment on attachment 9019012 [details] Bug 1498898 - Don't draw container-only widgets, r=jhorak [Triage Comment] Fixes a spurious console warning on Linux. Approved for 64.0b6.
Attachment #9019012 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Updated•5 years ago
|
Flags: qe-verify-
Comment 10•5 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/2bb12341b0fd
You need to log in
before you can comment on or make changes to this bug.
Description
•