Closed Bug 1498898 Opened 2 years ago Closed 2 years ago
Terminal warnings "Unknown widget type" when cursor passes over elements in toolbox
46 bytes, text/x-phabricator-request
|Details | Review|
Since Bug 1498356, when the mouse cursor passes over different elements in the toolbox, the following warning appears repeatedly in the terminal: > ** (firefox:3240): WARNING **: 18:04:15.167: Unknown widget type: 95
I have the same problem with: 64.0a1 (2018-10-16) (64-bit) status-firefox64: --- → affected
That's because we introduced a MOZ_GTK_HEADER_BAR_BUTTON_BOX widget but we don't want to draw it. I'm thinking of the best way how to handle it.
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/0a63507e990c Don't draw container-only widgets, r=jhorak
Comment on attachment 9019012 [details] Bug 1498898 - Don't draw container-only widgets, r=jhorak [Beta/Release Uplift Approval Request] Feature/Bug causing the regression: Bug 1498356 User impact if declined: Error messages on command line when titlebar is disabled Is this code covered by automated tests?: No Has the fix been verified in Nightly?: Yes Needs manual test from QE?: No If yes, steps to reproduce: List of other uplifts needed: None Risk to taking this patch: Low Why is the change risky/not risky? (and alternatives if risky): Minor code change in theme rendering. String changes made/needed: none
Attachment #9019012 - Flags: approval-mozilla-beta?
Comment on attachment 9019012 [details] Bug 1498898 - Don't draw container-only widgets, r=jhorak [Triage Comment] Fixes a spurious console warning on Linux. Approved for 64.0b6.
Attachment #9019012 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.