Closed Bug 14989 Opened 21 years ago Closed 18 years ago

ramiro's stack-trace hack should be on by default

Categories

(Core Graveyard :: Cmd-line Features, defect, P1)

All
Linux
defect

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.1beta

People

(Reporter: dmose, Assigned: dbaron)

Details

Attachments

(3 files)

Casual users of the milestone builds need to be given enough information to

encourage them to easily file useful bugs.  As such, it seems to me that M10 and

 later should by default be built either with ramiro's stack trace code turned

on
or else mozilla-apprunner.so should default to using libSegFault.so.
Target Milestone: M10
Summary: libSegFault.so or ramiro's stack-trace hack should be default → ramiro's stack-trace hack (+ maybe libSegFault.so) should be default
Turns out that libSegFault.so as shipped with RH6 doesn't seem to give useful
stack traces for multi-threaded executables.  It does, however, dump the
registers (which might conceivably be helpful in some case).  So ramiro's hack
is definitely the one that counts.
shaver, whatcha goin' n do?  time to wrap m10.
I don't know what the effects of Ramiro's hack are on non-Linux platforms, etc.
I'm comfortable having it turned on if we think it's not a big risk for our
other Unix platforms.
So maybe the right thing to do is turn it on in the tip right now, and that will
help us shake out any problems in time to ship M11 with it on by default.
Sold.

Who's going to flip the bit?
Target Milestone: M10 → M11
We're turning this on for M11, not M10.
Let's turn it on in the default build now, and see if it kicks anyone's ass.

Leaf, can you do the honours?
Sure... i take it the means of turning this on is buried somewhere in
n.p.m.unix.
Assignee: shaver → leaf
Status: ASSIGNED → NEW
Status: NEW → ASSIGNED
Target Milestone: M11 → M12
I am completely lame. I'll turn this on after M11 ships, and we can test it
before the alpha release. (now that i know where to look)
Status: ASSIGNED → NEW
Target Milestone: M12 → M13
can someone post what the hack is in this bug report.
seems like we need to get a few people to try this out
at the begining of a milestone period, not at the end.
we are at the end again..  m12 shutdown starts tomorrow..
leaf's got other stuff to do durning the milestone period...

lets get a few xheads to try the patch on a few platforms
when the hack gets posted here..
the hack is broken.  some checkins broke it and its rotten now.  sorry
Any idea what it would take to fix it?
Target Milestone: M13 → M14
I'm a big loser. Not going to make this in m13.
Target Milestone: M14 → M17
Note that this code also has the useful function of causing mozilla to go to
sleep after a crash so that one can attach to it with a debugger.  This is very
handy on linux, since linux cannot dump useful cores for multithreaded apps.
testing patch.
Status: NEW → ASSIGNED
tested on linux, seems to be working. How should i give this to reviewers@? The
patch itself that dmose has attached is tiny, but it turns on a bunch of other
stuff.
It seems to work.  However, I don't know if I like the long 5 minute time out
and it just looks like a hang to a user.  Do we want it turned off for non-debug
builds?
You're right, the sleep should be turned off for non-debug builds and the
message to stderr modified to match.
leger is no longer @netscape.com
changing qa contact to default for this component
QA Contact: leger → doronr
We were discussing this on IRC today... I'll take the bug and try to get an
appropriate form of the patch in...
Assignee: leaf → dbaron
Status: ASSIGNED → NEW
Component: Browser-General → XP Apps: Cmd-line Features
Summary: ramiro's stack-trace hack (+ maybe libSegFault.so) should be default → ramiro's stack-trace hack should be on by default
Target Milestone: M17 → mozilla0.9
Code looks fine -- if it works, sr=brendan@mozilla.org

/be
I'm thinking maybe this should be for DEBUG builds only.  I'm worried it:
 * might mess up talkback
 * wouldn't be too useful on builds with --enable-strip-libs

The reason I haven't checked it in yet is that it's rather intertwined with my
changes for bug 66159.
Part of my reasoning for wanting this is for people who download the nightlies
without talkback (in part because it seems like talkback goes through phases of
not working in one or the other of the installer or zip packaging).  But both of
these potential problems shouldn't be hard to test to see if they really cause
problems, I would think.
On my own non-debug build, which doesn't have --enable-strip-libs, the
stack traces are only barely useful, because the demangled symbols are
all NSGetModule, so the only way to get any useful information is through
addr2line, which will give the correct function names (but not line
numbers).  However, I suspect that with --enable-strip-libs, it won't
even be able to do that.  I guess I could try an --enable-strip-libs
build sometime...
OK, I've been running with this in my opt build for a few weeks now, and it's
caused some problems that make me not want to check it in for opt builds, and
perhaps not even at all.

In some cases I will see a crash and this code will go into an infinite loop
repeatedly printing the stack trace.  I'm not sure whether I've seen this in my
DEBUG build (where the timeout wasn't #ifdef-ed), but I know I've seen it in my
non-DEBUG build.

When this happens when I exit mozilla, I don't really notice.  However, since
I'm running my opt build from the gnome-panel rather than from an xterm window,
it spews this infinite loop to .xsession-errors, which fills up my /home
partition (yes, it fills 2.5GB of empty space) and causes my gnome/mozilla
profile data to get corrupted when programs attempt to write configurations back
to disk.  This has happened to me 3 or 4 times in the past week.

I'm not sure whether this can happen with the debugger-timeout enabled, but it's
*very* annoying, so I suggest that this shouldn't go in for optimized builds at
least until someone fixes the problem of infinite stack traces (for sure).
Since I really need to get the stuff in bug 66159 tested on Windows and Mac,
moving this to mozilla 0.9.1
Target Milestone: mozilla0.9 → mozilla0.9.1
Status: NEW → ASSIGNED
Just some comments here.  I use this on a day to day basis in my opt builds.  It
would be nice to have a --enable-stacktrace or something that:

o Turned on the stack trace code
o Turned off the elf-dynstr stripper
o Added -g to CFLAGS and CXXFLAGS so symbols would work



looks like this is something that could be move off to 0.9.2..
Target Milestone: mozilla0.9.1 → mozilla0.9.2
It's part of a larger patch that I'd still like to land for 0.9.1 that involves
a bit of rearrangement of debug-only code.
Target Milestone: mozilla0.9.2 → mozilla0.9.1
I don't know if this is useful but have you looked at glibc's
undocumented backtrace* functions?
Pushing out again.  I'll try to land this early in 0.9.2.  Really.  (I should
have time this time around.)
Target Milestone: mozilla0.9.1 → mozilla0.9.2
FWIW, the backtrace* functions are nicely documented in /usr/include/execinfo.h
I guess I'm a purist but the include file documents a particular
implementation of the functions not the functions themselves, but that's
not important here.
Target Milestone: mozilla0.9.2 → mozilla0.9.3
Target Milestone: mozilla0.9.3 → mozilla0.9.4
Target Milestone: mozilla0.9.4 → mozilla0.9.5
Target Milestone: mozilla0.9.5 → mozilla0.9.6
Target Milestone: mozilla0.9.6 → mozilla0.9.7
Target Milestone: mozilla0.9.7 → mozilla0.9.6
Comment on attachment 46617 [details] [diff] [review]
up-to-date patch, DEBUG only (see above)

r=bryner
Attachment #46617 - Flags: review+
Comment on attachment 46617 [details] [diff] [review]
up-to-date patch, DEBUG only (see above)

sr=brendan@mozilla.org -- what's not to love?

/be
Attachment #46617 - Flags: superreview+
All fixes except for turning it on checked in.
Target Milestone: mozilla0.9.6 → mozilla0.9.7
->0.9.8, since I haven't sent out newsgroup posts about this yet.  (Somebody
remind me in two weeks or something so I don't notice this at the very end of
every milestone. :-)
Target Milestone: mozilla0.9.7 → mozilla0.9.8
Reminding...
Target Milestone: mozilla0.9.8 → mozilla0.9.9
Target Milestone: mozilla0.9.9 → mozilla1.0
Target Milestone: mozilla1.0 → mozilla1.1beta
Priority: P3 → P1
Remainder of patch checked in to trunk, 2002-07-04 22:31 PDT.
Can something like this be used to fix bug 148453 on non-debug builds?
So, does anyone else think anything else should be done for this bug, or should
I close it?  (Perhaps other things to do should be filed as separate bugs?)

I'm against turning it on for opt builds based on the experiences I've had with
it filling up my .xsession-errors until my disk was full, and also since the opt
stacks aren't too useful because of the way we strip symbols out of components.
Closing this sounds fine.  Other improvements can be filed as new bugs.  Thanks
for doing this.
Yanking myself from cc.
OK, fixed then.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
QA Contact: doronr → cmd-line
You need to log in before you can comment on or make changes to this bug.