1498910 - Crash in CreateDrawTargetForSurface

Status: RESOLVED WORKSFORME

(Core :: Graphics: Layers, defect)

Description

[Julian Seward [:jseward]]

This bug was filed from the Socorro interface and is
report bp-97bb982e-ac84-4afb-aee0-9a1af0181012.
=============================================================

This failed with
MOZ_CRASH(CreateDrawTargetForSurface failed in plugin)
in two different installations of the Windows nightly of 20181011100123.

Top 10 frames of crashing thread:

0 xul.dll static class RefPtr<mozilla::gfx::DrawTarget> CreateDrawTargetForSurface dom/plugins/ipc/PluginInstanceChild.cpp:117
1 xul.dll void mozilla::plugins::PluginInstanceChild::PaintRectToSurface dom/plugins/ipc/PluginInstanceChild.cpp:3441
2 xul.dll bool mozilla::plugins::PluginInstanceChild::ShowPluginFrame dom/plugins/ipc/PluginInstanceChild.cpp:3747
3 xul.dll void mozilla::plugins::PluginInstanceChild::InvalidateRectDelayed dom/plugins/ipc/PluginInstanceChild.cpp:3885
4 xul.dll nsresult mozilla::detail::RunnableMethodImpl<mozilla::dom::ServiceWorkerRegistration*, void  xpcom/threads/nsThreadUtils.h:1242
5 xul.dll bool MessageLoop::DeferOrRunPendingTask ipc/chromium/src/base/message_loop.cc:459
6 xul.dll MessageLoop::DoWork ipc/chromium/src/base/message_loop.cc:534
7 xul.dll base::MessagePumpForUI::DoRunLoop ipc/chromium/src/base/message_pump_win.cc:211
8 xul.dll base::MessagePumpWin::Run ipc/chromium/src/base/message_pump_win.h:80
9 xul.dll MessageLoop::RunHandler ipc/chromium/src/base/message_loop.cc:311

=============================================================

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

David, any ideas?

Comment 2

[Jim Mathies [:jimm]]

I have this queued up.

Comment 3

[Andrew Osmond [:aosmond] (he/him)]

The only way it should fail is here:

https://searchfox.org/mozilla-central/rev/eef79962ba73f7759fd74da658f6e5ceae0fc730/gfx/2d/DrawTargetCairo.cpp#1914

But the crash reports don't seem to contain the extra gfx logging like usual. Does that not get saved with plugin processes?

Comment 4

[Jim Mathies [:jimm]]

No crashes in latest builds over the last month.