1498953 - Broke audio on listen/pronunciation button on Google search

Status: VERIFIED FIXED

(Core :: Audio/Video: Playback, defect, P2)

Description

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

STRs:
 1. Open https://www.google.com/search?q=belie
 2. Click 🔊 (speaker) "Listen" button.

Expected result:
  Audio pronunciation of word "belie"

Actual result:
  Silence.

Regression range:

49:14.25 INFO: Last good revision: b8b3597d7702e4e6d7c3358f19384b49d8c220c0
49:14.25 INFO: First bad revision: 25bff27f9944c7bfea0372c2b6dc55e35977fb83
49:14.25 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=b8b3597d7702e4e6d7c3358f19384b49d8c220c0&tochange=25bff27f9944c7bfea0372c2b6dc55e35977fb83

alwu — Bug 1496281 - do not create audio stream if audio has ended. r=jya

Comment 1

[Alastor Wu [:alwu]]

I'll backout the change in bug1496281, it seems that my change has some flaws, thanks!

Comment 2

[Alastor Wu [:alwu]]

Solved by backout bug1496281.

Comment 3

[Cristian Fogel [:cfogel]]

Confirmed issue on Win10x64, with Firefox 64.0a1 (20181014223729); it was also reproducible on Ubuntu 16.04 with older beta builds.
Regarding STR, I've accessed the following link https://www.dictionary.com and the issue was also reproducible.

Verified the "fix" using 64.0b4 and 65.0a1 (2018-10-28) on macOS 10.14, Ubuntu16.04 and Windows10; issue is no longer reproducible. For good measure I've also checked with other websites as well.