1498966 - configure doesn't error out when building cranelift if we couldn't find clang

Status: NEW

(Firefox Build System :: General, enhancement)

Description

[Emilio Cobos Álvarez (:emilio)]

See https://mozilla.logbot.info/developers/20181015#c15464883.

If you hit this path when building the JS engine with cranelift enabled:

  https://searchfox.org/mozilla-central/rev/3a54520d8d2319a4116866371ed3d9ed2ec0cc2b/build/moz.configure/bindgen.configure#126

Then you get an error like http://termbin.com/zj3u5.

JS should probably be added to the bindgen_projects variable right above, but I guess we don't want to make it unconditionally if cranelift is disabled?

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Error (for reference, not sure when the pastebin expires)

Comment 2

[Benjamin Bouvier [:bbouvier] (inactive)]

Good catch, thanks. Nathan, should we unconditionally force Bindgen to be there for JS, even though the only Rust code under JS is Nightly only now?

Otherwise, I guess I could just add something like --enable-cranelift onto the @depends, and then check this and project == 'js' to conditionally show the error message.

Comment 3

[Benjamin Bouvier [:bbouvier] (inactive)]

Apparently, depending on --enable-cranelift isn't possible since this option is defined after the code in bindgen.configure is run; so we'd have to require clang all the time for JS, even though we might not end up using it.

There's been some messages on the mailing-lists (dev platform and JS internals at least), so it sounds like it would be appropriate to unconditionally require libclang et al. for building JS?

Comment 4

[Mike Hommey [:glandium]]

You should be able to use imply_option.