Closed Bug 1499016 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 13516 - Add URL parsing test for "ssh://github.com/test/repo.git"

Categories

(Core :: DOM: Core & HTML, enhancement, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla65
Tracking Flags:
Tracking Status
firefox65 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream]) 

Sync web-platform-tests PR 13516 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/13516
Details from upstream follow.

Philip Jägenstedt <philip@foolip.org> wrote:
>  Add URL parsing test for "ssh://github.com/test/repo.git"
>  
>  Exercised in url-constructor.html and url/url-origin.html.
>  
>  Points of disagreement:
>   * `protocol` should be "ssh:" because it is simply the concatenation of
>     scheme and ":": https://url.spec.whatwg.org/#dom-url-protocol. Set to
>     "ssh" here: https://url.spec.whatwg.org/#scheme-state
>   * `origin` should be "null" because the URL will be get an opaque
>     origin in https://url.spec.whatwg.org/#concept-url-origin.
>   * `host`, `hostname` and `pathname` require stepping through the parser
>     to see why the result is what it is:
>     https://url.spec.whatwg.org/#host-state
>     https://url.spec.whatwg.org/#path-state
>  
>  Based on https://felixfbecker.github.io/whatwg-url-custom-host-repro/
>  for https://github.com/webcompat/web-bugs/issues/19792.
Component: web-platform-tests → DOM
Product: Testing → Core
Ran 7 tests and 2770 subtests
OK     : 7
PASS   : 1846
FAIL   : 924

New tests that have failures or other problems:
/url/a-element-xhtml.xhtml
    Parsing: <ssh://example.com/foo/bar.git> against <http://example.org/>: FAIL
/url/a-element.html
    Parsing: <ssh://example.com/foo/bar.git> against <http://example.org/>: FAIL
/url/url-constructor.html
    Parsing: <ssh://example.com/foo/bar.git> against <http://example.org/>: FAIL
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f2bd9ae62c82
[wpt PR 13516] - Add URL parsing test for "ssh://example.com/foo/bar.git", a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/d83f3f8a5d22
[wpt PR 13516] - Update wpt metadata, a=testonly
https://hg.mozilla.org/mozilla-central/rev/f2bd9ae62c82
https://hg.mozilla.org/mozilla-central/rev/d83f3f8a5d22
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.