1499036 - moz-wptsync-bot corrupted UTF-16 files when syncing wpt to upstream

Status: NEW

(Testing :: web-platform-tests, enhancement)

Description

[Henri Sivonen (:hsivonen)]

In https://github.com/web-platform-tests/wpt/commit/3d778629a3948660e510f8b4f2b22c26fa4ad727 , moz-wptsync-bot corrupted a UTF-16BE file and a UTF-16LE file when syncing to wpt upstream.

Manual fix of the two files is https://github.com/web-platform-tests/wpt/pull/13519

Comment 1

[James Graham [:jgraham]]

(FWIW there is a GH repo at mozilla/wpt-sync that has the actual code in it, but issues here isn't a huge problem)

It looks like the Git library was defaulting to converting output of commands to UTF8 so we generated a UTF8 formatted patch to export. Obviously that doesn't work, and just using bytes everywhere does, so I've opted out of the implicit conversion. I think that will fix things.