Closed Bug 1499075 Opened 10 months ago Closed 10 months ago

Remove OSX special-casing for web-platform-test chunking

Categories

(Firefox Build System :: Task Configuration, task)

task
Not set

Tracking

(firefox-esr60 fixed, firefox64 fixed)

RESOLVED FIXED
mozilla64
Tracking Status
firefox-esr60 --- fixed
firefox64 --- fixed

People

(Reporter: RyanVM, Assigned: RyanVM)

Details

Attachments

(1 file)

We have this weird situation at the moment were OSX opt builds run wpt in 5 chunk, debug builds in 10 chunks, and Nightly builds in 12. This is because there's some OSX special-casing going back to the buildbot days for opt & debug builds and a default condition specifying 12.

OSX chunks run much longer than other platforms as a result (and I only noticed this discrepancy while waiting on them to finish during a tree closure situation) and I think we should just remove the special-casing and bring them in line with all the other plaforms.
Joel, I'm posting a patch for you to review. If you disagree with the general premise, feel free to r- and just wontfix the bug :).
Assignee: nobody → ryanvm
Flags: needinfo?(jmaher)
I don't have an opinion on whether this change makes sense. I suspect the reasoning behind having less chunks for osx is that we have a fixed number of workers (since they are hardware workers). Having tests split in to less chunks (which is true of many tests, not just wpt) means that no one push can monopolize all the testers. I'm not sure if this tradeoff makes sense, still, or if we have enough workers that it isn't a concern.
It also saves on setup/teardown overhead, I expect, which is important with a fixed set of available machine-hours.
commented in phabricator
Flags: needinfo?(jmaher)
Attachment #9017175 - Attachment description: Bug 1499075 - Remove OSX special-casing for wpt chunking. r=jmaher → Bug 1499075 - Adjust the number of OSX wpt chunks for more consistent runtimes with other platforms. r=jmaher
Pushed by rvandermeulen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8ec57c7e3057
Adjust the number of OSX wpt chunks for more consistent runtimes with other platforms. r=jmaher
https://hg.mozilla.org/mozilla-central/rev/8ec57c7e3057
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.