Closed Bug 1499153 Opened Last year Closed Last year

Remove obsolete manifest check and NO_JS_MANIFEST

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set

Tracking

(firefox64 fixed)

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1438688 made it so that XPT	information is compiled directly into the binary instead of being shipped separately in interface files. This means that manifests are no longer necessary for JS components, which means the manifest check in emitter.py can be removed.

That check is the only use of NO_JS_MANIFEST, so that can in turn be removed entirely.
Blocks: 1499155
Bug 1438688 made it so that XPT information is compiled directly into
the binary instead of being shipped separately in interface
files. This means that manifests are no longer necessary for JS
components, which means the manifest check in emitter.py can be
removed.

That check is the only use of NO_JS_MANIFEST, so that can in turn be
removed entirely.
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/55bb23a27ec7
Remove obsolete manifest check and NO_JS_MANIFEST r=glandium
https://hg.mozilla.org/mozilla-central/rev/55bb23a27ec7
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.