1499235 - Intermittent LeakSanitizer | leak at mozilla::net::WebSocketChannelChild::AsyncOpen, mozilla::dom::WebSocketImpl::AsyncOpen, mozilla::dom::WebSocket::ConstructorCommon, mozilla::dom::WebSocket::Constructor, mozilla::dom::WebSocket_Binding::_constructor, C

Status: RESOLVED DUPLICATE of bug 1497947

(Core :: Networking: WebSockets, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: btara [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=205623233&repo=mozilla-inbound

https://queue.taskcluster.net/v1/task/EEM04HgqTfCJJikk6QFTwg/runs/0/artifacts/public/logs/live_backing.log

[task 2018-10-15T21:50:33.370Z] 21:50:33     INFO - Browser exited with return code 0
[task 2018-10-15T21:50:33.371Z] 21:50:33     INFO - ERROR | LeakSanitizer | SUMMARY: AddressSanitizer: 3180 byte(s) leaked in 26 allocation(s).
[task 2018-10-15T21:50:33.372Z] 21:50:33     INFO - LeakSanitizer | To show the addresses of leaked objects add report_objects=1 to LSAN_OPTIONS
[task 2018-10-15T21:50:33.373Z] 21:50:33     INFO - This can be done in testing/mozbase/mozrunner/mozrunner/utils.py
[task 2018-10-15T21:50:33.374Z] 21:50:33     INFO - Allowed depth was 7
[task 2018-10-15T21:50:33.375Z] 21:50:33     INFO - TEST-FAIL | LeakSanitizer | leak at Alloc, nsTSubstring, nsTSubstring, nsTSubstring, operator=, nsContentUtils::GetASCIIOrigin, nsContentUtils::GetASCIIOrigin
[task 2018-10-15T21:50:33.376Z] 21:50:33     INFO - INFO | LeakSanitizer | Frame Alloc matched a expected leak
[task 2018-10-15T21:50:33.377Z] 21:50:33     INFO - TEST-FAIL | LeakSanitizer | leak at Alloc, nsTSubstring, nsTSubstring, mozilla::net::nsStandardURL::BuildNormalizedSpec, mozilla::net::nsStandardURL::SetSpecWithEncoding, mozilla::net::nsStandardURL::Init, Init
[task 2018-10-15T21:50:33.377Z] 21:50:33     INFO - INFO | LeakSanitizer | Frame Alloc matched a expected leak
[task 2018-10-15T21:50:33.378Z] 21:50:33     INFO - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at mozilla::net::WebSocketChannelChild::AsyncOpen, mozilla::dom::WebSocketImpl::AsyncOpen, mozilla::dom::WebSocket::ConstructorCommon, mozilla::dom::WebSocket::Constructor, mozilla::dom::WebSocket_Binding::_constructor, CallJSNative, CallJSNativeConstructor
[task 2018-10-15T21:50:33.378Z] 21:50:33     INFO - TEST-FAIL | LeakSanitizer | leak at CreateInner, Create, nsAtomTable::Atomize, mozilla::BasePrincipal::FinishInit, mozilla::ContentPrincipal::Init, mozilla::BasePrincipal::CreateCodebasePrincipal, mozilla::BasePrincipal::CreateCodebasePrincipal
[task 2018-10-15T21:50:33.379Z] 21:50:33     INFO - INFO | LeakSanitizer | Frame CreateInner matched a expected leak
[task 2018-10-15T21:50:33.379Z] 21:50:33     INFO - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at mozilla::dom::WebSocket::ConstructorCommon, mozilla::dom::WebSocket::Constructor, mozilla::dom::WebSocket_Binding::_constructor, CallJSNative, CallJSNativeConstructor, InternalConstruct, Interpret
[task 2018-10-15T21:50:33.380Z] 21:50:33     INFO - TEST-FAIL | LeakSanitizer | leak at Alloc, nsTSubstring, Gecko_StartBulkWriteCString, nsstring::nsACString::start_bulk_write_impl::hf4db67941dd47dec, nsstring::nsACString::bulk_write::h757086ea5377d348, nsstring::conversions::_$LT$impl$u20$nsstring..nsACString$GT$::fallible_append_utf16_to_utf8_impl::h0702ecc5f563262c, nscstring_fallible_append_utf16_to_utf8_impl
[task 2018-10-15T21:50:33.381Z] 21:50:33     INFO - INFO | LeakSanitizer | Frame Alloc matched a expected leak
[task 2018-10-15T21:50:33.382Z] 21:50:33     INFO - TEST-FAIL | LeakSanitizer | leak at mozilla::WeakPtr, WeakPtr, mozilla::Maybe, mozilla::ContentPrincipal::AddonPolicy, nsIDocument::InitCSP, nsDocument::StartDocumentLoad, nsHTMLDocument::StartDocumentLoad
[task 2018-10-15T21:50:33.383Z] 21:50:33     INFO - INFO | LeakSanitizer | Frame mozilla::WeakPtr matched a expected leak
[task 2018-10-15T21:50:33.383Z] 21:50:33     INFO - TEST-FAIL | LeakSanitizer | leak at Alloc, nsTSubstring, nsTSubstring, nsTSubstring, operator=, mozilla::dom::WebSocketImpl::Init, mozilla::dom::WebSocket::ConstructorCommon
[task 2018-10-15T21:50:33.384Z] 21:50:33     INFO - INFO | LeakSanitizer | Frame Alloc matched a expected leak
[task 2018-10-15T21:50:33.385Z] 21:50:33     INFO - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at mozilla::net::WebSocketEventService::GetOrCreate, mozilla::dom::WebSocketImpl::Init, mozilla::dom::WebSocket::ConstructorCommon, mozilla::dom::WebSocket::Constructor, mozilla::dom::WebSocket_Binding::_constructor, CallJSNative, CallJSNativeConstructor
[task 2018-10-15T21:50:33.387Z] 21:50:33     INFO - TEST-FAIL | LeakSanitizer | leak at mozilla::dom::WebSocket::WebSocket, mozilla::dom::WebSocket::ConstructorCommon, mozilla::dom::WebSocket::Constructor, mozilla::dom::WebSocket_Binding::_constructor, CallJSNative, CallJSNativeConstructor, InternalConstruct
[task 2018-10-15T21:50:33.387Z] 21:50:33     INFO - INFO | LeakSanitizer | Frame mozilla::dom::WebSocket::WebSocket matched a expected leak
[task 2018-10-15T21:50:33.388Z] 21:50:33     INFO - TEST-FAIL | LeakSanitizer | leak at Alloc, nsTSubstring, nsTSubstring, nsTSubstring, nsTSubstring, operator=, nsContentUtils::GetUTFOrigin
[task 2018-10-15T21:50:33.388Z] 21:50:33     INFO - INFO | LeakSanitizer | Frame Alloc matched a expected leak
[task 2018-10-15T21:50:33.389Z] 21:50:33     INFO - TEST-FAIL | LeakSanitizer | leak at mozilla::net::nsStandardURL::TemplatedMutator, Init, mozilla::net::nsStandardURL::TemplatedMutator, operator, std::_Function_handler, operator, Apply
[task 2018-10-15T21:50:33.389Z] 21:50:33     INFO - INFO | LeakSanitizer | Frame mozilla::net::nsStandardURL::TemplatedMutator matched a expected leak
[task 2018-10-15T21:50:33.389Z] 21:50:33     INFO - TEST-FAIL | LeakSanitizer | leak at mozilla::SchedulerGroup::CreateEventTargetFor, mozilla::SchedulerGroup::CreateEventTargets, mozilla::dom::TabGroup::TabGroup, mozilla::dom::nsIContentChild::GetConstructedEventTarget, mozilla::ipc::IToplevelProtocol::ToplevelState::GetMessageEventTarget, GetMessageEventTarget, mozilla::ipc::MessageChannel::MessageTask::Post
[task 2018-10-15T21:50:33.390Z] 21:50:33     INFO - INFO | LeakSanitizer | Frame mozilla::SchedulerGroup::CreateEventTargetFor matched a expected leak
[task 2018-10-15T21:50:33.391Z] 21:50:33     INFO - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at MakeUnique, mozilla::dom::ClientInfo::operator=, emplace, GetClientInfo, nsPIDOMWindowInner::GetClientInfo, nsIDocument::GetClientInfo, mozilla::net::LoadInfo::LoadInfo
[task 2018-10-15T21:50:33.392Z] 21:50:33     INFO - TEST-FAIL | LeakSanitizer | leak at Alloc, nsTSubstring, Gecko_StartBulkWriteString, nsstring::nsAString::start_bulk_write_impl::hd448164831349eca, nsstring::nsAString::bulk_write::h477f53610373ed77, nsstring::conversions::_$LT$impl$u20$nsstring..nsAString$GT$::fallible_append_utf8_impl::h305a62bbd4e59778, nsstring_fallible_append_utf8_impl
[task 2018-10-15T21:50:33.393Z] 21:50:33     INFO - INFO | LeakSanitizer | Frame Alloc matched a expected leak

Comment 1

[Valentin Gosu [:valentin] {{ PTO 3 July - 3 August }}]

This was revealed by bug 1467914 which removed "Init" from the list of expected leaks, which also matched WebSocketImpl::Init.

Comment 2

[Intermittent Failures Robot]

6 failures in 2759 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 1
* autoland: 2
* mozilla-beta: 3

Platform breakdown:
* linux64: 6

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1499235&startday=2018-10-15&endday=2018-10-21&tree=all

Comment 3

[Intermittent Failures Robot]

2 failures in 2584 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-beta: 2

Platform breakdown:
* linux64: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1499235&startday=2018-10-22&endday=2018-10-28&tree=all

Comment 4

[Valentin Gosu [:valentin] {{ PTO 3 July - 3 August }}]

I think the websocket leaks were "fixed" (added to the allowlist) in bug 1497947.
The latest failures have a completely different trace:
TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at operator=, WeakPtr, emplace, mozilla::ContentPrincipal::AddonPolicy, nsIDocument::InitCSP, nsDocument::StartDocumentLoad, nsHTMLDocument::StartDocumentLoad 

I'll file a different bug for that.

Comment 5

[Valentin Gosu [:valentin] {{ PTO 3 July - 3 August }}]

(In reply to Valentin Gosu [:valentin] from comment #4)
> The latest failures have a completely different trace:
> TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at operator=, WeakPtr, emplace,
> mozilla::ContentPrincipal::AddonPolicy, nsIDocument::InitCSP,
> nsDocument::StartDocumentLoad, nsHTMLDocument::StartDocumentLoad 
> 
> I'll file a different bug for that.

Actually, there's already a bug for that (bug 1482952)

Comment 6

[Intermittent Failures Robot]

1 failures in 2978 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 1

Platform breakdown:
* linux64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1499235&startday=2018-10-29&endday=2018-11-04&tree=all