Remove the customizable ui toolbar-menubar-autohide binding

RESOLVED FIXED in Firefox 64

Status

()

P1
normal
RESOLVED FIXED
5 months ago
5 months ago

People

(Reporter: bgrins, Assigned: Gijs)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 64
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox64 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 months ago
See discussion starting at https://bugzilla.mozilla.org/show_bug.cgi?id=1498740#c4.

This binding (https://searchfox.org/mozilla-central/rev/c9272ef398954288525e37196eada1e5a93d93bf/browser/components/customizableui/content/toolbar.xml#170) can be removed and replaced with JS running somewhere from browser.xul, since this is a 1-binding-per-browser-window setup.
(Reporter)

Comment 1

5 months ago
Gijs, filed as discussed in https://bugzilla.mozilla.org/show_bug.cgi?id=1498740#c5. Is this something you'd have cycles to grab? If not, do you have any more information to add here for whoever takes it as far as where the ported code should live / get initialized?
Component: XUL Widgets → Toolbars and Customization
Flags: needinfo?(gijskruitbosch+bugs)
Product: Toolkit → Firefox
(Assignee)

Updated

5 months ago
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Flags: needinfo?(gijskruitbosch+bugs)
(Assignee)

Comment 4

5 months ago
(In reply to :Gijs (he/him) from comment #3)
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=123784e962859809902dcfcf657ca4fd90ebd44b

Hm, this seems to trip up the reflow test for window opening on Windows (but not linux...). I'll need to investigate why when I'm back on my Windows machine.

Comment 6

5 months ago
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/5c84e7821c57
remove customizableui menubar binding, r=Felipe

Comment 7

5 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/5c84e7821c57
Status: ASSIGNED → RESOLVED
Last Resolved: 5 months ago
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
You need to log in before you can comment on or make changes to this bug.