Closed Bug 1499254 Opened Last year Closed Last year

beetmover-repackage transforms shouldn't crawl the dependency tree

Categories

(Firefox Build System :: Task Configuration, task)

task
Not set

Tracking

(firefox-esr60 fixed, firefox65 fixed)

RESOLVED FIXED
mozilla65
Tracking Status
firefox-esr60 --- fixed
firefox65 --- fixed

People

(Reporter: aki, Assigned: aki)

References

(Blocks 1 open bug)

Details

Attachments

(4 files, 2 obsolete files)

Aka, beetmover multidep.

Currently, beetmover kinds use the single_dep loader, which gives us a single upstream dependency. Then the beetmover transforms look at the deps of the single upstream dependency and add those deps. This is ugly and fragile and difficult to refactor.

We've introduced a multi_dep loader that can do this in a more elegant way.
- switch beetmover-l10n, beetmover-source, and beetmover kinds to
multi_dep
- add the platform-l10n-chunk group-by-fn.
- add the filter_for_attributes function

Depends on D9196
Attachment #9018494 - Attachment is obsolete: true
Attachment #9018498 - Attachment is obsolete: true
Summary: beetmover transforms shouldn't crawl the dependency tree → beetmover-repackage transforms shouldn't crawl the dependency tree
Pushed by asasaki@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6f85b1efc3d2
sort reverse_chunk_deps for easier diffing. r=tomprince
https://hg.mozilla.org/integration/autoland/rev/2eea4d6c1597
add primary-dependency support. r=tomprince,Callek
https://hg.mozilla.org/integration/autoland/rev/848914c4c934
beetmover_repackage{,_l10n} multi-dep. r=tomprince
https://hg.mozilla.org/integration/autoland/rev/f99c22e6f6b1
fake-multi-dep is no longer needed. r=tomprince
Blocks: 1501878
You need to log in before you can comment on or make changes to this bug.