Closed Bug 1499284 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 13537 - Revert "[css-layout-api] Add LayoutEdges."

Categories

(Testing :: web-platform-tests, enhancement, P4)

Product:
Testing
Component:
web-platform-tests
Type:
enhancement

Tracking

(firefox65 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla65
Tracking Flags:
Tracking Status
firefox65 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream]) 

Sync web-platform-tests PR 13537 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/13537
Details from upstream follow.

Findit <findit-for-me@appspot.gserviceaccount.com> wrote:
>  Revert "[css-layout-api] Add LayoutEdges."
>  
>  This reverts commit 980bc9b6532b0980721c123fa29fa561bc503f91.
>  
>  Reason for revert:
>  
>  Findit (https://goo.gl/kROfz5) identified CL at revision 599680 as the
>  culprit for flakes in the build cycles as shown on:
>  https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vOTgwYmM5YjY1MzJiMDk4MDcyMWMxMjNmYTI5ZmE1NjFiYzUwM2Y5MQw
>  
>  Sample Failed Build: https://ci.chromium.org/buildbot/chromium.mac/Mac10.10%20Tests/35414
>  
>  Sample Failed Step: webkit_layout_tests on (none) GPU on Mac on Mac-10.10.5
>  
>  Sample Flaky Test: external/wpt/css/css-layout-api/edges/scrollbar.https.html
>  
>  Original change's description:
>  > [css-layout-api] Add LayoutEdges.
>  > 
>  > This allows web developers to access pre-computed sizes for the border,
>  > scrollbar, and padding "edges".
>  > 
>  > This adds two types of tests:
>  > 1) Uses the standard "green box" approach of testing the script values
>  >    match what is expected.
>  > 2) Positions four children at each corner (using edges) are positioned
>  >    the same as using an abs-pos technique.
>  > 
>  > Bug: 726125
>  > Change-Id: I3b53be9b44989d919cb657d4eabc6d3a1a79181b
>  > Reviewed-on: https://chromium-review.googlesource.com/c/1252776
>  > Commit-Queue: Ian Kilpatrick \<ikilpatrick@chromium.org>
>  > Reviewed-by: Aleks Totic \<atotic@chromium.org>
>  > Reviewed-by: Morten Stenshorne \<mstensho@chromium.org>
>  > Cr-Commit-Position: refs/heads/master@{#599680}
>  
>  Change-Id: Ib4f9cb3e51daa57412d31cff71cbf0a3fe15cab9
>  No-Presubmit: true
>  No-Tree-Checks: true
>  No-Try: true
>  Bug: 726125, 895731
>  Reviewed-on: https://chromium-review.googlesource.com/c/1282724
>  Cr-Commit-Position: refs/heads/master@{#599889}
>
PR 13537 applied with additional changes from upstream: 8c024e160ccff17edde16ed3989689d36e6ca085
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3118aea5b380
[wpt PR 13537] - Revert "[css-layout-api] Add LayoutEdges.", a=testonly
https://hg.mozilla.org/mozilla-central/rev/3118aea5b380
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.