Closed Bug 1499358 Opened Last year Closed Last year

Snippets Simple Template Schema incompatibility with button_url

Categories

(Firefox :: New Tab Page, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 64
Iteration:
65.1 - Nov 2
Tracking Status
firefox64 --- fixed

People

(Reporter: giorgos, Assigned: andreio)

References

Details

Attachments

(1 file)

The current (not ASR) Simple Snippets Template takes `button_url` as an argument to display an optional button.

This was implemented similarly in ASR and merged into Firefox 63 Beta.

Unfortunately it was silently changed to `button_args` and `button_args_options` in nightly which is troublesome.

We now have 2 versions of the same template without a proper version bump, or agreement on how to handle different versions on different channels.

The Snippets Service has implemented `button_url` and we expect to serve Snippets in Beta, Dev and Nightly with ASR as soon as 63 hits release. 

This bug is to track needed actions to ensure that current Snippet Templates are compatible with ASR Snippet Templates and that the LCM team will be able to publish snippets in the mentioned channels.
Component: New Tab Page → Activity Streams: Newtab
Assignee: nobody → andrei.br92
Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/7193c4c61247fd98fc1e1ae18a4302ad343da3ce
Fix Bug 1499358 - Add button_url field to schema as fallback for OPEN_URL (#4503)

* Fix Bug 1499358 - Add button_url field to schema as fallback for OPEN_URL

* Add comment
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Blocks: 1499886
Iteration: --- → 65.1 (Nov 2)
Priority: -- → P1
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.