Closed
Bug 1499358
Opened 6 years ago
Closed 6 years ago
Snippets Simple Template Schema incompatibility with button_url
Categories
(Firefox :: New Tab Page, enhancement, P1)
Firefox
New Tab Page
Tracking
()
Tracking | Status | |
---|---|---|
firefox64 | --- | fixed |
People
(Reporter: giorgos, Assigned: andreio)
References
Details
Attachments
(1 file)
The current (not ASR) Simple Snippets Template takes `button_url` as an argument to display an optional button. This was implemented similarly in ASR and merged into Firefox 63 Beta. Unfortunately it was silently changed to `button_args` and `button_args_options` in nightly which is troublesome. We now have 2 versions of the same template without a proper version bump, or agreement on how to handle different versions on different channels. The Snippets Service has implemented `button_url` and we expect to serve Snippets in Beta, Dev and Nightly with ASR as soon as 63 hits release. This bug is to track needed actions to ensure that current Snippet Templates are compatible with ASR Snippet Templates and that the LCM team will be able to publish snippets in the mentioned channels.
Reporter | ||
Updated•6 years ago
|
Component: New Tab Page → Activity Streams: Newtab
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → andrei.br92
Comment 1•6 years ago
|
||
Comment 2•6 years ago
|
||
Commit pushed to master at https://github.com/mozilla/activity-stream https://github.com/mozilla/activity-stream/commit/7193c4c61247fd98fc1e1ae18a4302ad343da3ce Fix Bug 1499358 - Add button_url field to schema as fallback for OPEN_URL (#4503) * Fix Bug 1499358 - Add button_url field to schema as fallback for OPEN_URL * Add comment
Updated•6 years ago
|
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Iteration: --- → 65.1 (Nov 2)
Updated•6 years ago
|
Priority: -- → P1
Comment 3•6 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/826cd78b94cb
status-firefox64:
--- → fixed
Target Milestone: --- → Firefox 64
Updated•5 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•