1499361 - Permafailing test_TelemetrySession.js | test_environmentChange - [test_environmentChange : 962] "undefined" deepEqual when Gecko 64 merges to Beta on 2018-10-15

Status: VERIFIED FIXED

(Toolkit :: Telemetry, defect)

Description

[Cosmin Sabou [:CosminS]]

central as beta: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed,busted,exception&revision=20ff6a370c03e1f22cc9fe559ed521f3a20b6035&searchStr=xpc&selectedJob=205798058

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=205798274&repo=try&lineNumber=3789

This looks like a regression from https://hg.mozilla.org/mozilla-central/rev/45a7ec8b7021#l3.31, https://bugzilla.mozilla.org/show_bug.cgi?id=1497365.  Robert can you take a look at this?

Comment 1

[Jan-Erik Rediger [:janerik]]

Ah, most likely because prio is not enabled on non-nightly[1].
Probably best to wrap that in an if like in [2] for the time being.

[1]:  https://searchfox.org/mozilla-central/rev/c9272ef398954288525e37196eada1e5a93d93bf/browser/app/profile/firefox.js#1777-1779
[2]: https://searchfox.org/mozilla-central/rev/c9272ef398954288525e37196eada1e5a93d93bf/toolkit/components/telemetry/tests/unit/test_TelemetrySession.js#406-408

Comment 2

[Robert Helmer [:rhelmer]]

(In reply to Jan-Erik Rediger [:janerik] from comment #1)
> Ah, most likely because prio is not enabled on non-nightly[1].
> Probably best to wrap that in an if like in [2] for the time being.
> 
> [1]: 
> https://searchfox.org/mozilla-central/rev/
> c9272ef398954288525e37196eada1e5a93d93bf/browser/app/profile/firefox.js#1777-
> 1779
> [2]:
> https://searchfox.org/mozilla-central/rev/
> c9272ef398954288525e37196eada1e5a93d93bf/toolkit/components/telemetry/tests/
> unit/test_TelemetrySession.js#406-408

Just coming here to say :) I'll do that in this bug, thanks!

Comment 3

[Robert Helmer [:rhelmer]]

Attachment: Bug 1499361 - skip Prio telemetry tests if prio.enabled is false r?janerik

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f0952bbb1671
skip Prio telemetry tests if prio.enabled is false r=janerik

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/f0952bbb1671

Comment 7

[Sebastian Hengst [:aryx] (needinfo on intermittent or backout)]

Verified fixed with today's beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&revision=b7d861abc991f5ad2a307cb1b44793146c42848e&selectedJob=206088740