Closed
Bug 1499361
Opened 2 years ago
Closed 2 years ago
Permafailing test_TelemetrySession.js | test_environmentChange - [test_environmentChange : 962] "undefined" deepEqual when Gecko 64 merges to Beta on 2018-10-15
Categories
(Toolkit :: Telemetry, defect)
Toolkit
Telemetry
Tracking
()
VERIFIED
FIXED
mozilla64
Tracking | Status | |
---|---|---|
firefox64 | --- | verified |
People
(Reporter: CosminS, Assigned: rhelmer)
References
Details
Attachments
(1 file)
central as beta: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed,busted,exception&revision=20ff6a370c03e1f22cc9fe559ed521f3a20b6035&searchStr=xpc&selectedJob=205798058 Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=205798274&repo=try&lineNumber=3789 This looks like a regression from https://hg.mozilla.org/mozilla-central/rev/45a7ec8b7021#l3.31, https://bugzilla.mozilla.org/show_bug.cgi?id=1497365. Robert can you take a look at this?
Flags: needinfo?(rhelmer)
Comment 1•2 years ago
|
||
Ah, most likely because prio is not enabled on non-nightly[1]. Probably best to wrap that in an if like in [2] for the time being. [1]: https://searchfox.org/mozilla-central/rev/c9272ef398954288525e37196eada1e5a93d93bf/browser/app/profile/firefox.js#1777-1779 [2]: https://searchfox.org/mozilla-central/rev/c9272ef398954288525e37196eada1e5a93d93bf/toolkit/components/telemetry/tests/unit/test_TelemetrySession.js#406-408
Assignee | ||
Comment 2•2 years ago
|
||
(In reply to Jan-Erik Rediger [:janerik] from comment #1) > Ah, most likely because prio is not enabled on non-nightly[1]. > Probably best to wrap that in an if like in [2] for the time being. > > [1]: > https://searchfox.org/mozilla-central/rev/ > c9272ef398954288525e37196eada1e5a93d93bf/browser/app/profile/firefox.js#1777- > 1779 > [2]: > https://searchfox.org/mozilla-central/rev/ > c9272ef398954288525e37196eada1e5a93d93bf/toolkit/components/telemetry/tests/ > unit/test_TelemetrySession.js#406-408 Just coming here to say :) I'll do that in this bug, thanks!
Flags: needinfo?(rhelmer)
Assignee | ||
Comment 3•2 years ago
|
||
Assignee | ||
Updated•2 years ago
|
Assignee: nobody → rhelmer
Status: NEW → ASSIGNED
Pushed by rhelmer@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f0952bbb1671 skip Prio telemetry tests if prio.enabled is false r=janerik
Comment 5•2 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f0952bbb1671
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Verified fixed with today's beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&revision=b7d861abc991f5ad2a307cb1b44793146c42848e&selectedJob=206088740
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•