Closed Bug 1499394 Opened Last year Closed 3 months ago

Refactor PromptDelegate/PermissionDelegate to use GeckoResult rather than callbacks

Categories

(GeckoView :: General, enhancement, P3)

53 Branch
All
Android
enhancement

Tracking

(firefox69 wontfix, firefox70 fixed)

RESOLVED FIXED
mozilla70
Tracking Status
firefox69 --- wontfix
firefox70 --- fixed

People

(Reporter: droeh, Assigned: droeh)

Details

Attachments

(3 files, 1 obsolete file)

Refactoring PromptDelegate and PermissionDelegate to use GeckoResults rather than callbacks will bring them more in line with the rest of the API.
Product: Firefox for Android → GeckoView
Attachment #9082689 - Attachment is obsolete: true
Pushed by droeh@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/77fa1072f8a8
[1.0] Kill off old PromptDelegate, PromptCallback, and handlePromptEvent. r=geckoview-reviewers,snorp
https://hg.mozilla.org/integration/autoland/rev/438452cc4e22
[2.0] Add new PromptDelegate and handlePromptEvent. r=geckoview-reviewers,snorp,rbarker
https://hg.mozilla.org/integration/autoland/rev/595a0c78c402
[3.0] Update tests, BasicGeckoViewActivity, and CHANGELOG around PromptDelegate changes. r=geckoview-reviewers,snorp
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70

69=wontfix because I assume we don't need to uplift this PromptDelegate/PermissionDelegate refactoring to GV 69 Beta.

You need to log in before you can comment on or make changes to this bug.