Closed Bug 1499397 Opened 2 years ago Closed 2 years ago

ServiceWorker tests should run with cookiePolicy 0

Categories

(Core :: DOM: Security, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: baku, Assigned: baku)

References

Details

(Whiteboard: [domsecurity-active])

Attachments

(1 file)

When testing bug 1492563, I realized that many ServiceWorker tests are broken because they run nested iframes, and they are not allowed with cookiePolicy == 4. This cookiePolicy doesn't give storage access to nested iframes because they can be used to track the users using DOM Cache, via SW.

But we want those tests! This bug is about configure these tests to run them with cookiePolicy == 0.
Status: NEW → ASSIGNED
Priority: -- → P2
Whiteboard: [domsecurity-active]
Attached patch fix_1.patchSplinter Review
Attachment #9017593 - Flags: review?(ehsan)
Comment on attachment 9017593 [details] [diff] [review]
fix_1.patch

Review of attachment 9017593 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/serviceworkers/test/mochitest.ini
@@ +1,3 @@
>  [DEFAULT]
> +prefs =
> +  network.cookie.cookieBehavior=0

Thanks!  Maybe also add a comment about why this is necessary?  r=me with that.
Attachment #9017593 - Flags: review?(ehsan) → review+
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/525a441d5dd3
ServiceWorker tests should run with cookiePolicy 0, r=ehsan
https://hg.mozilla.org/mozilla-central/rev/525a441d5dd3
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.