1499397 - ServiceWorker tests should run with cookiePolicy 0

Status: RESOLVED FIXED

(Core :: DOM: Security, enhancement, P2)

Description

[Andrea Marchesini [:baku]]

When testing bug 1492563, I realized that many ServiceWorker tests are broken because they run nested iframes, and they are not allowed with cookiePolicy == 4. This cookiePolicy doesn't give storage access to nested iframes because they can be used to track the users using DOM Cache, via SW.

But we want those tests! This bug is about configure these tests to run them with cookiePolicy == 0.

Comment 1

[Andrea Marchesini [:baku]]

Attachment: fix_1.patch

Comment 2

[(no longer active)]

Comment on attachment 9017593 [details] [diff] [review]
fix_1.patch

Review of attachment 9017593 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/serviceworkers/test/mochitest.ini
@@ +1,3 @@
>  [DEFAULT]
> +prefs =
> +  network.cookie.cookieBehavior=0

Thanks!  Maybe also add a comment about why this is necessary?  r=me with that.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/525a441d5dd3
ServiceWorker tests should run with cookiePolicy 0, r=ehsan

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/525a441d5dd3