Intermitent AddressSanitizer: heap-use-after-free /builds/worker/workspace/build/src/dom/media/webrtc/MediaEngineWebRTCAudio.cpp:1042:7 in mozilla::AudioInputProcessing::Pull(RefPtr<mozilla::AllocationHandle const> const&, RefPtr<mozilla::SourceMediaStrea
Categories
(Core :: WebRTC: Audio/Video, defect, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr60 | --- | unaffected |
firefox63 | --- | unaffected |
firefox64 | + | wontfix |
firefox65 | + | fixed |
firefox66 | + | fixed |
People
(Reporter: aiakab, Assigned: padenot)
References
(Blocks 1 open bug)
Details
(Keywords: csectype-uaf, intermittent-failure, sec-high, Whiteboard: [post-critsmash-triage][adv-main65+])
Attachments
(1 file, 1 obsolete file)
47 bytes,
text/x-phabricator-request
|
abillings
:
approval-mozilla-beta+
abillings
:
sec-approval+
|
Details | Review |
Updated•7 years ago
|
Updated•7 years ago
|
Updated•7 years ago
|
Updated•7 years ago
|
Comment 2•7 years ago
|
||
Assignee | ||
Comment 3•7 years ago
|
||
Comment 4•7 years ago
|
||
Assignee | ||
Comment 5•6 years ago
|
||
Assignee | ||
Comment 6•6 years ago
|
||
Comment 7•6 years ago
|
||
Updated•6 years ago
|
Assignee | ||
Comment 8•6 years ago
|
||
Assignee | ||
Comment 9•6 years ago
|
||
Comment 10•6 years ago
|
||
![]() |
||
Comment 11•6 years ago
|
||
uplift |
![]() |
||
Comment 12•6 years ago
|
||
Comment 13•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 16•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 17•6 years ago
|
||
Take two, green try and locally as well: https://treeherder.mozilla.org/#/jobs?repo=try&revision=52a362c890e9a0dd94f55006779ae3b1bc2b70fd
Assignee | ||
Comment 18•6 years ago
|
||
Comment on attachment 9035651 [details]
Bug 1499426 - Align the lifetime of AudioInputProcessing with the lifetime of MediaEngineWebRTCAudio. r?achronop
[Beta/Release Uplift Approval Request]
Feature/Bug causing the regression: Bug 1487057
User impact if declined: Rare crash maybe (5 occurrences on treeherder in 2 months)
Is this code covered by automated tests?: Yes
Has the fix been verified in Nightly?: No
Needs manual test from QE?: No
If yes, steps to reproduce:
List of other uplifts needed: None
Risk to taking this patch: Low
Why is the change risky/not risky? (and alternatives if risky): If it's green on try it's going to be fine, this code is very how in our test suite. Last patch was wrong and all the test broke.
String changes made/needed: none
[Security Approval Request]
How easily could an exploit be constructed based on the patch?: Quite hard I think, you have to align 3 threads, including a real-time thread, the main thread, and another thread.
Do comments in the patch, the check-in comment, or tests included in the patch paint a bulls-eye on the security problem?: Yes
Which older supported branches are affected by this flaw?: beta
If not all supported branches, which bug introduced the flaw?: Bug 1487057
Do you have backports for the affected branches?: Yes
If not, how different, hard to create, and risky will they be?:
How likely is this patch to cause regressions; how much testing does it need?: If it's green it's fine.
Comment 19•6 years ago
|
||
sec-approval+ for trunk and on beta after talking to Ryan.
Updated•6 years ago
|
Reporter | ||
Comment 20•6 years ago
|
||
Backed out changeset 0f68913927a5 (bug 1499426) for mochitest failure on MediaEngineWebRTCAudio CLOSED TREE
Backout revision https://hg.mozilla.org/integration/autoland/rev/b5b1f341206d87c70036b2f35f8ae9604e29535f
Failure log https://treeherder.mozilla.org/logviewer.html#?job_id=221358482&repo=autoland
:padenot Could you please take a look?
Assignee | ||
Comment 21•6 years ago
|
||
Hrm forgot to update the variable that let us assert, new patch up shortly.
Assignee | ||
Comment 22•6 years ago
|
||
Updated•6 years ago
|
Comment 23•6 years ago
|
||
Comment 24•6 years ago
|
||
uplift |
Thanks for driving this over the finish line, Paul!
https://hg.mozilla.org/releases/mozilla-beta/rev/8d48fc5df525
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Updated•5 years ago
|
Description
•