Closed Bug 1499428 Opened 11 months ago Closed 11 months ago

Remove display="xul:menu" on menulist and menulist-popuponly

Categories

(Toolkit :: XUL Widgets, task)

task
Not set

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: bgrins, Assigned: bgrins)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

I'm not entirely sure why we need this: https://bgrins.github.io/xbl-analysis/tree/#menulist / https://searchfox.org/mozilla-central/rev/3d989d097fa35afe19e814c6d5bc2f2bf10867e1/toolkit/content/widgets/menulist.xml#13

We'll need to figure out what this is used for and see how it can be removed (see other bugs blocking 1450652 for other examples).
Should adding a case for menulist here be enough? https://searchfox.org/mozilla-central/rev/3d989d097fa35afe19e814c6d5bc2f2bf10867e1/layout/base/nsCSSFrameConstructor.cpp#4182. Or are there other parts of platform code (accessibility, etc) where we need to make sure that the overridden node name isn't relied on?
Flags: needinfo?(emilio)
Yeah, adding a case there should be enough.
Flags: needinfo?(emilio)
Instead, set the NS_NewMenuFrame directly on menulist elements.
Did an artifact push (which covers just the [display] removal) and am seeing a bunch of failures: https://treeherder.mozilla.org/#/jobs?repo=try&revision=28d5f32f5b65dc24e87430fa55c4b59eb3919650. Those are fixed with the full build that sets up the frame: https://treeherder.mozilla.org/#/jobs?repo=try&revision=38f481d9a3cd019e7327354094b1361cfd37d53b, so it must be doing something right.
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Pushed by bgrinstead@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c19d5002228f
Remove display="xul:menu" on menulist and menulist-popuponly;r=emilio
https://hg.mozilla.org/mozilla-central/rev/c19d5002228f
Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Blocks: 1499832
Flags: qe-verify-
Type: enhancement → task
You need to log in before you can comment on or make changes to this bug.