1499429 - GeckoEditable is not properly transferred during session transfer

Status: RESOLVED FIXED

(GeckoView :: General, enhancement, P2)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

During a session transfer we want to update all relevant GeckoEditableChild instances in the parent and child processes to use the new GeckoEditableParent associated with the new session.

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Bug 1499429 - 1. Notify child process of session transfer; r?esawin

Notify child process when we have a session transfer so the child
process can update accordingly.

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Bug 1499429 - 2. Set default GeckoEditableChild from native code; r?esawin

Set the default GeckoEditableChild from C++, so we can keep the same
GeckoEditableChild instance across session transfers, and only have a
different GeckoEditableParent instance after each transfer.

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Bug 1499429 - 3. Transfer to new GeckoEditableParent during session transfer; r?esawin

During a session transfer, update existing GeckoEditableChild instances
in the parent and child processes to use the new GeckoEditableParent
instance that corresponds to the new session. If the GeckoEditableChild
has focus, take additional steps to make sure the GeckoEditableParent
receives current input context and focus information.

Comment 4

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Bug 1499429 - 4. Add a test for session transfer with focused input; r?esawin

Add a test for the prior patches. Check that during a session transfer,
SessionTextInput is properly transferred and any focused state is
preserved.

Comment 5

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Bug 1499429 - 5. Make setting editable parent async; r?esawin

Currently we make a sync call from the child process to the parent
process to retrieve the IGeckoEditableParent instance. However, that can
lead to deadlocks when a11y code makes parent-to-child async calls at
the same time. This patch makes the call async to avoid the deadlock.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cbd9846ee234
1. Notify child process of session transfer; r=esawin
https://hg.mozilla.org/integration/mozilla-inbound/rev/4d2e501b020d
2. Set default GeckoEditableChild from native code; r=esawin
https://hg.mozilla.org/integration/mozilla-inbound/rev/7688a1109239
3. Transfer to new GeckoEditableParent during session transfer; r=esawin
https://hg.mozilla.org/integration/mozilla-inbound/rev/578c92bc890e
4. Add a test for session transfer with focused input; r=esawin
https://hg.mozilla.org/integration/mozilla-inbound/rev/5b53442956cd
5. Make setting editable parent async; r=esawin

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e0782f337548
6. Fix up for checkstyle errors; r=me

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/cbd9846ee234
https://hg.mozilla.org/mozilla-central/rev/4d2e501b020d
https://hg.mozilla.org/mozilla-central/rev/7688a1109239
https://hg.mozilla.org/mozilla-central/rev/578c92bc890e
https://hg.mozilla.org/mozilla-central/rev/5b53442956cd
https://hg.mozilla.org/mozilla-central/rev/e0782f337548

Comment 9

[Chris Peterson [:cpeterson]]

status-geckoview64=wontfix