1499435 - Icons cannot be placed next to menu any more.

Status: RESOLVED FIXED

(Thunderbird :: Toolbars and Tabs, defect)

Description

[thomas.hebinck]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:62.0) Gecko/20100101 Firefox/62.0

Steps to reproduce:

I try to have the icons next to the menu (File, Edit, ... [Send], [Save]). (via customize toolbars)


Actual results:

This doesn't work any more in Compose- and Read-windows. It only works in the main window.


Expected results:

Icons should be placed next to the menu everywhere, like it was always.
Exact version is 60.2.1 (64-bit) on Ubuntu

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1499435-menubar.patch

We need that our binding is used and not the one from m-c. I haven't seen a menubar which isn't inside a toolbox, so this should be safe.

Comment 2

[:aceman]

Comment on attachment 9017893 [details] [diff] [review]
1499435-menubar.patch

Review of attachment 9017893 [details] [diff] [review]:
-----------------------------------------------------------------

So this increases specificity so that our binding is chosen?
Can't we use a different name for the binding to avoid clashes? We should do something similar in the textbox case. Yeah, that would hit addons, so probably not doable... :(

Comment 3

[Richard Marti (:Paenglab)]

(In reply to :aceman from comment #2)
> Comment on attachment 9017893 [details] [diff] [review]
> 1499435-menubar.patch
> 
> Review of attachment 9017893 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> So this increases specificity so that our binding is chosen?

Yes.

> Can't we use a different name for the binding to avoid clashes? We should do
> something similar in the textbox case. Yeah, that would hit addons, so
> probably not doable... :(

The binding itself would be no problem. But the specificity wouldn't change. Renaming the toolbar could work but this would end in renaming this in many XUL files and we still use toolkit binding which would also needed to be adapted in some way.

Comment 4

[:aceman]

Comment on attachment 9017893 [details] [diff] [review]
1499435-menubar.patch

Review of attachment 9017893 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, works for me.

Comment 5

[:aceman]

Comment on attachment 9017893 [details] [diff] [review]
1499435-menubar.patch

[Approval Request Comment]

Without the patch, dragging items from the customize palette to a place next to the menu produces:
TypeError: toolbar.insertItem is not a function, customizeToolbar.js:746

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ba6de8f2e729
Fix customization of menubar. r=aceman

Comment 7

[Jorg K (CEST = GMT+2)]

Please add some meaningful commit messages. I moved the
  Use our toolbar[type="menubar"]:not([autohide="true"]) and not the toolkit one.
below as a comment.

Comment 8

[Jorg K (CEST = GMT+2)]

TB 63 beta 2:
https://hg.mozilla.org/releases/comm-beta/rev/9f2613f9c323e393a0ab8a0ee248444290555fe5

Comment 9

[Jorg K (CEST = GMT+2)]

TB 60.3 ESR:
https://hg.mozilla.org/releases/comm-esr60/rev/35c8a5030a71d16293e74c9c7f8aed0f800649de