1499444 - Save to pocket button doesn't work on first click after a startup

Status: RESOLVED FIXED

(Firefox :: Pocket, defect)

Description

[Scott [:thecount] Downe]

STR:

1. Start browser.
2. Go to any page that's savable to pocket, like not about:home, example: https://www.google.com/
3. Click the save to pocket icon in the address bar.

Expected: Should see "Saved to Pocket" dialog after a brief "saving..." period.
Actual: Stays stuck in the "saving..." period and just spins and spins.

Clicking again after a moment or going to a new page and trying it there should work.

Comment 1

[Scott [:thecount] Downe]

Attachment: Fixes bug 1499444 - Save to pocket button doesn't work on first click after a startup

Comment 2

[Scott [:thecount] Downe]

Not sure who to get to review this quite yet, but both Shane Caraveo and Justin Dolske have modified this code, so maybe either of you can take a look?

Comment 3

[Scott [:thecount] Downe]

Maybe this is something you're familiar with enough to do a review?

Comment 4

[Drew Willcoxon :adw]

r+'ed with comments, thanks

Comment 5

[Scott [:thecount] Downe]

Updated based on your comments, good finds, thanks!

Comment 6

[Drew Willcoxon :adw]

Thanks, r+

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8594386886d1
Fixes bug 1499444 - Save to pocket button doesn't work on first click after a startup r=adw

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/8594386886d1