Closed
Bug 1499444
Opened 7 years ago
Closed 7 years ago
Save to pocket button doesn't work on first click after a startup
Categories
(Firefox :: Pocket, defect)
Tracking
()
RESOLVED
FIXED
Firefox 64
Tracking | Status | |
---|---|---|
firefox64 | --- | fixed |
People
(Reporter: thecount, Assigned: thecount)
Details
Attachments
(1 file)
STR:
1. Start browser.
2. Go to any page that's savable to pocket, like not about:home, example: https://www.google.com/
3. Click the save to pocket icon in the address bar.
Expected: Should see "Saved to Pocket" dialog after a brief "saving..." period.
Actual: Stays stuck in the "saving..." period and just spins and spins.
Clicking again after a moment or going to a new page and trying it there should work.
Assignee | ||
Comment 1•7 years ago
|
||
Assignee | ||
Comment 2•7 years ago
|
||
Not sure who to get to review this quite yet, but both Shane Caraveo and Justin Dolske have modified this code, so maybe either of you can take a look?
Flags: needinfo?(mixedpuppy)
Flags: needinfo?(dolske)
Assignee | ||
Comment 3•7 years ago
|
||
Maybe this is something you're familiar with enough to do a review?
Flags: needinfo?(adw)
Updated•7 years ago
|
Status: NEW → ASSIGNED
Comment 4•7 years ago
|
||
r+'ed with comments, thanks
Flags: needinfo?(mixedpuppy)
Flags: needinfo?(dolske)
Flags: needinfo?(adw)
Assignee | ||
Comment 5•7 years ago
|
||
Updated based on your comments, good finds, thanks!
Flags: needinfo?(adw)
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ebalazs@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8594386886d1
Fixes bug 1499444 - Save to pocket button doesn't work on first click after a startup r=adw
Keywords: checkin-needed
Comment 8•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Updated•7 years ago
|
QA Whiteboard: [good first verify]
You need to log in
before you can comment on or make changes to this bug.
Description
•