Closed Bug 1499444 Opened 2 years ago Closed 2 years ago

Save to pocket button doesn't work on first click after a startup

Categories

(Firefox :: Pocket, defect)

Product:
Firefox
Component:
Pocket
Version:
64 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 64
Tracking Flags:
Tracking Status
firefox64 --- fixed

People

(Reporter: thecount, Assigned: thecount)

Details

Attachments

(1 file)

Fixes bug 1499444 - Save to pocket button doesn't work on first click after a startup
46 bytes, text/x-phabricator-request
Details | Review 
STR:

1. Start browser.
2. Go to any page that's savable to pocket, like not about:home, example: https://www.google.com/
3. Click the save to pocket icon in the address bar.

Expected: Should see "Saved to Pocket" dialog after a brief "saving..." period.
Actual: Stays stuck in the "saving..." period and just spins and spins.

Clicking again after a moment or going to a new page and trying it there should work.
Not sure who to get to review this quite yet, but both Shane Caraveo and Justin Dolske have modified this code, so maybe either of you can take a look?
Flags: needinfo?(mixedpuppy)
Flags: needinfo?(dolske)
Maybe this is something you're familiar with enough to do a review?
Flags: needinfo?(adw)
Status: NEW → ASSIGNED
r+'ed with comments, thanks
Flags: needinfo?(mixedpuppy)
Flags: needinfo?(dolske)
Flags: needinfo?(adw)
Updated based on your comments, good finds, thanks!
Flags: needinfo?(adw)
Thanks, r+
Flags: needinfo?(adw)
Keywords: checkin-needed
Pushed by ebalazs@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8594386886d1
Fixes bug 1499444 - Save to pocket button doesn't work on first click after a startup r=adw
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/8594386886d1
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox64: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
QA Whiteboard: [good first verify]
You need to log in before you can comment on or make changes to this bug.