Closed Bug 1499524 Opened Last year Closed Last year

Mail Toolbar should show when there are no items

Categories

(Thunderbird :: Theme, defect)

defect
Not set

Tracking

(thunderbird_esr6063+ fixed, thunderbird63 wontfix, thunderbird64 fixed)

RESOLVED FIXED
Thunderbird 64.0
Tracking Status
thunderbird_esr60 63+ fixed
thunderbird63 --- wontfix
thunderbird64 --- fixed

People

(Reporter: ovari123, Assigned: Paenglab)

Details

Attachments

(3 files)

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:62.0) Gecko/20100101 Firefox/62.0

Steps to reproduce:

1. Cutomize the Mail Toolbar
2. Remove all the items on the Mail Toolbar
3. When the last item is removed, the Mail Toolbar placeholder disappears


Actual results:

The Mail Toolbar disappears when there are no items. (incorrect)

The Folder Pane Toolbar shows when there are no items. (correct)


Expected results:

When there are no items in the Mail Toolbar, and the Mail Toolbar is active, the Mail Toolbar should show.

The Folder Pane Toolbar still shows when there are no items.

Linux Mint 19 Cinnamon
Thunderbird 60.2.1.
THis happened in safe mode?
Flags: needinfo?(ovari123)
(In reply to Wayne Mery (:wsmwk) from comment #1)
> THis happened in safe mode?

This also happens in safe mode.
Flags: needinfo?(ovari123)
Linux is the only platform which has no min-height in toolbars.css. This patch adds it to messenger.css.
Assignee: nobody → richard.marti
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #9018674 - Flags: review?(acelists)
The same patch applying on ESR and beta.
Attachment #9018675 - Flags: approval-comm-esr60?
Attachment #9018675 - Flags: approval-comm-beta?
(In reply to Richard Marti (:Paenglab) from comment #4)
> Created attachment 9018675 [details] [diff] [review]
> 1499524-toolbarMinHeight-Beta-ESR.patch
> 
> The same patch applying on ESR and beta.

Will this patch apply to all toolbars, i.e. in add-ons, too?

Thank you
When they use messenger.css, yes.
Comment on attachment 9018674 [details] [diff] [review]
1499524-toolbarMinHeight.patch

Review of attachment 9018674 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, the toolbar suddenly going missing (zero height) looks weird to the user.
Attachment #9018674 - Flags: review?(acelists) → review+
Keywords: checkin-needed
Attachment #9018675 - Flags: approval-comm-esr60?
Attachment #9018675 - Flags: approval-comm-esr60+
Attachment #9018675 - Flags: approval-comm-beta?
Attachment #9018675 - Flags: approval-comm-beta+
Component: Untriaged → Theme
Target Milestone: --- → Thunderbird 64.0
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/c7cffab8f15a
Set toolbars a min-height on Linux. r=aceman
Status: ASSIGNED → RESOLVED
Closed: Last year
Keywords: checkin-needed
Resolution: --- → FIXED
Comment on attachment 9018675 [details] [diff] [review]
1499524-toolbarMinHeight-Beta-ESR.patch

Too late for 63 beta now.
Attachment #9018675 - Flags: approval-comm-beta+
You need to log in before you can comment on or make changes to this bug.