1499536 - ARM64: Implement visitShiftI and visitUrshD

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, enhancement)

Description

[Sean Stangl [:sstangl]]

Attachment: 0001-Implement-CodeGeneratorARM64-visitShiftI-and-visitUr.patch

Straightforward patch. Fixes ion/bug1000960.js.

Comment 1

[Matthew Gaudet (he/him) [:mgaudet]]

Comment on attachment 9017698 [details] [diff] [review]
0001-Implement-CodeGeneratorARM64-visitShiftI-and-visitUr.patch

Review of attachment 9017698 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, but one question before I r+, if you don't mind.

::: js/src/jit/arm64/CodeGenerator-arm64.cpp
@@ +569,5 @@
>  CodeGenerator::visitShiftI(LShiftI* ins)
>  {
> +    const ARMRegister lhs = toWRegister(ins->lhs());
> +    const LAllocation* rhs = ins->rhs();
> +    const ARMRegister dest = toWRegister(ins->getDef(0));

This is the only piece I don't really follow; why isn't this ins->output()?

Comment 2

[Sean Stangl [:sstangl]]

It could be. LShiftI is LInstructionFixedDefsTempsHelper, which defines `->output()` as `->getDefs(0)`, so they're the same.

Comment 3

[Sean Stangl [:sstangl]]

Attachment: Same patch with ins->output()

Same patch but with ins->output() instead of ins->getDef(0).

Comment 4

[Matthew Gaudet (he/him) [:mgaudet]]

Comment on attachment 9019157 [details] [diff] [review]
Same patch with ins->output()

Review of attachment 9019157 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7884434cddde
Implement CodeGeneratorARM64::visitShiftI and visitUrshD. r=mgaudet

Comment 6

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/7884434cddde