Closed Bug 1499536 Opened 10 months ago Closed 10 months ago

ARM64: Implement visitShiftI and visitUrshD

Categories

(Core :: JavaScript Engine: JIT, enhancement)

ARM64
Unspecified
enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: sstangl, Assigned: sstangl)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Straightforward patch. Fixes ion/bug1000960.js.
Attachment #9017698 - Flags: review?(jitbugs)
Attachment #9017698 - Flags: review?(jitbugs) → review?(mgaudet)
Comment on attachment 9017698 [details] [diff] [review]
0001-Implement-CodeGeneratorARM64-visitShiftI-and-visitUr.patch

Review of attachment 9017698 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, but one question before I r+, if you don't mind.

::: js/src/jit/arm64/CodeGenerator-arm64.cpp
@@ +569,5 @@
>  CodeGenerator::visitShiftI(LShiftI* ins)
>  {
> +    const ARMRegister lhs = toWRegister(ins->lhs());
> +    const LAllocation* rhs = ins->rhs();
> +    const ARMRegister dest = toWRegister(ins->getDef(0));

This is the only piece I don't really follow; why isn't this ins->output()?
It could be. LShiftI is LInstructionFixedDefsTempsHelper, which defines `->output()` as `->getDefs(0)`, so they're the same.
Same patch but with ins->output() instead of ins->getDef(0).
Attachment #9017698 - Attachment is obsolete: true
Attachment #9019157 - Flags: review?(mgaudet)
Comment on attachment 9019157 [details] [diff] [review]
Same patch with ins->output()

Review of attachment 9019157 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #9019157 - Flags: review?(mgaudet) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/7884434cddde
Implement CodeGeneratorARM64::visitShiftI and visitUrshD. r=mgaudet
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/7884434cddde
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.