1499548 - [wpt-sync] Sync PR 13552 - [ci] Filter GitHub pull request events

Status: RESOLVED FIXED

(Testing :: web-platform-tests, enhancement, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 13552 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/13552
Details from upstream follow.

Mike Pennisi <[e-mail]> wrote:
>  [ci] Filter GitHub pull request events
>  
>  We've been validating pull requests on Taskcluster far more often than we need to. [This dummy pull request submitted to Bocoup's fork of WPT demonstrates the various events.](https://github.com/bocoup/wpt/pull/8 ) The GitHub UI only displays the latest status, so it's necessary to query the HTTP API to see the complete status history:
>  
>      $ curl --silent https://api.github.com/repos/bocoup/wpt/commits/e9dcdf611/statuses | \
>        python -c 'import sys, json; print "\n".join(["{created_at} {description}".format(**x) for x in json.loads(sys.stdin.read())])'
>  
>  <details>
>    <summary>output</summary>
>  
>      2018-10-16T18:22:02Z TaskGroup: success
>      2018-10-16T18:14:49Z The Travis CI build passed
>      2018-10-16T18:14:09Z The Travis CI build passed
>      2018-10-16T18:09:20Z The Travis CI build is in progress
>      2018-10-16T18:08:51Z TaskGroup: success
>      2018-10-16T18:08:51Z The Travis CI build is in progress
>      2018-10-16T18:08:50Z The Travis CI build is in progress
>      2018-10-16T18:08:50Z The Travis CI build is in progress
>      2018-10-16T18:08:49Z The Travis CI build is in progress
>      2018-10-16T18:08:49Z The Travis CI build is in progress
>      2018-10-16T18:08:49Z The Travis CI build is in progress
>      2018-10-16T18:08:48Z The Travis CI build is in progress
>      2018-10-16T18:08:48Z The Travis CI build is in progress
>      2018-10-16T18:08:48Z The Travis CI build is in progress
>      2018-10-16T18:08:47Z The Travis CI build is in progress
>      2018-10-16T18:08:46Z TaskGroup: Pending (for pull_request.reopened)
>      2018-10-16T18:07:59Z TaskGroup: success
>      2018-10-16T18:07:53Z TaskGroup: Pending (for pull_request.closed)
>      2018-10-16T18:06:55Z TaskGroup: success
>      2018-10-16T18:06:49Z TaskGroup: Pending (for pull_request.unassigned)
>      2018-10-16T18:06:37Z TaskGroup: success
>      2018-10-16T18:06:06Z TaskGroup: Pending (for pull_request.assigned)
>      2018-10-16T18:05:25Z TaskGroup: success
>      2018-10-16T18:04:56Z TaskGroup: Pending (for pull_request.review_request_removed)
>      2018-10-16T18:04:03Z TaskGroup: success
>      2018-10-16T18:03:56Z TaskGroup: Pending (for pull_request.review_requested)
>      2018-10-16T18:02:06Z TaskGroup: success
>      2018-10-16T18:01:55Z TaskGroup: Pending (for pull_request.edited)
>      2018-10-16T18:01:51Z TaskGroup: Pending (for pull_request.edited)
>      2018-10-16T18:01:07Z The Travis CI build passed
>  
>  </details>
>  
>  Validating commits in response to many of these events is inefficient. The response to the "closed" event is particularly concerning.  Many people (and all scripts) delete the base branch immediately after merging a pull request. The subsequent validation attempt cannot run in this state, so it always fails. Because the GitHub UI only displays the latest commit status, this gives a false impression of the status at the moment the patch was accepted (for a real-world example of this, see gh-13045).
>  
>  [This dummy pull request demonstrates the behavior after this patch is applied.](https://github.com/bocoup/wpt/pull/10)
>  
>      $ curl --silent https://api.github.com/repos/bocoup/wpt/commits/03b1b7456a868d50adc/statuses | \
>        python -c 'import sys, json; print "\n".join(["{created_at} {description}".format(**x) for x in json.loads(sys.stdin.read())])'
>  
>  <details>
>    <summary>output</summary>
>  
>      2018-10-16T20:30:36Z The Travis CI build passed
>      2018-10-16T20:28:01Z The Travis CI build passed
>      2018-10-16T20:26:25Z The Travis CI build could not complete due to an error
>      2018-10-16T20:26:05Z TaskGroup: success
>      2018-10-16T20:23:52Z The Travis CI build is in progress
>      2018-10-16T20:23:51Z The Travis CI build is in progress
>      2018-10-16T20:23:49Z The Travis CI build is in progress
>      2018-10-16T20:23:48Z The Travis CI build is in progress
>      2018-10-16T20:23:46Z The Travis CI build is in progress
>      2018-10-16T20:23:45Z The Travis CI build is in progress
>      2018-10-16T20:23:44Z The Travis CI build is in progress
>      2018-10-16T20:23:43Z The Travis CI build is in progress
>      2018-10-16T20:23:41Z The Travis CI build is in progress
>      2018-10-16T20:23:40Z The Travis CI build is in progress
>      2018-10-16T20:23:37Z TaskGroup: Pending (for pull_request.reopened)
>      2018-10-16T20:22:55Z The Travis CI build is in progress
>      2018-10-16T20:21:42Z TaskGroup: success
>      2018-10-16T20:20:47Z The Travis CI build is in progress
>      2018-10-16T20:20:46Z The Travis CI build is in progress
>      2018-10-16T20:20:44Z The Travis CI build is in progress
>      2018-10-16T20:20:43Z The Travis CI build is in progress
>      2018-10-16T20:20:42Z The Travis CI build is in progress
>      2018-10-16T20:20:41Z The Travis CI build is in progress
>      2018-10-16T20:20:39Z The Travis CI build is in progress
>      2018-10-16T20:20:36Z The Travis CI build is in progress
>      2018-10-16T20:20:35Z The Travis CI build is in progress
>      2018-10-16T20:20:33Z The Travis CI build is in progress
>      2018-10-16T20:20:29Z TaskGroup: Pending (for pull_request.opened)
>  
>  </details>
>  
>  > The complete list of event "actions" emitted by GitHub (and recognized
>  > by Taskcluster) is [1]:
>  >
>  > > - assigned
>  > > - unassigned
>  > > - labeled
>  > > - unlabeled
>  > > - opened
>  > > - edited
>  > > - closed
>  > > - reopened
>  > > - synchronize
>  > > - review_requested
>  > > - review_request_removed
>  >
>  > Most of these have no bearing on the code under review, so they should
>  > not trigger validation.
>  >
>  > Do not validate commits in response to irrelevant events.
>  >
>  > [1] https://docs.taskcluster.net/docs/reference/integrations/taskcluster-github/references/events
>

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=389ee2911ec2f657944253e366133d3e30d32e5b

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8012b9a688d4
[wpt PR 13552] - [ci] Filter GitHub pull request events, a=testonly

Comment 3

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/8012b9a688d4