Closed Bug 1499559 Opened 8 years ago Closed 7 years ago

"Classification saved for..." banner getting stuck until the refresh of the page

Categories

(Tree Management :: Treeherder: Frontend, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: cbrindusan, Assigned: camd)

References

Details

Attachments

(1 file)

Attached image classification.png —
There is a situation in Treeherder where the "Classification saved for..." would get stuck until the refresh of the page. This happens randomly.
Flags: needinfo?(cdawson)
Summary: "Classification saved for..." stuck until the refresh of the page → "Classification saved for..." banner getting stuck until the refresh of the page
Blocks: 1450024
Component: Treeherder → Treeherder: Frontend
Priority: -- → P1
Assignee: nobody → cdawson
Status: NEW → ASSIGNED
Flags: needinfo?(cdawson)
Cam, can you prioritize this, please? It requires reloads of Treeherder which take some time to download the data for all pushes. Thank you.
Yes, I will try to get this fixed this week. But you should be able to hit escape to clear any on-screen notifications. I added that feature recently. Does that work to help prevent you from having to reload?
Flags: needinfo?(cdawson)
I'm not yet able to reproduce this. If anyone does, please check if there's an error message on the console. That might help point to the problem.
Talked to Cristin in IRC and he said he's not able to reproduce this after yesterday's push. I wonder if the change to class-level functions helped this. Either way, I'm going to back-burner this and perhaps mark it as WFM if we can't reproduce it soon.
Flags: needinfo?(cdawson)
Cristin: Thanks for the update. I'll try it out. So, when this happens, are you able to hit "esc" to clear them? Just curious if that is broken in this context as well. Though I'll try it myself, too. :)
I'm able to reproduce with classifying, too. Just classify a ton of jobs. Presumably >25 or so. It must be overloading something. Hitting "esc" DOES clear them, however. Working on a fix.
This will be fixed once it's pushed to production.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: