Closed
Bug 1499559
Opened 8 years ago
Closed 7 years ago
"Classification saved for..." banner getting stuck until the refresh of the page
Categories
(Tree Management :: Treeherder: Frontend, defect, P1)
Tree Management
Treeherder: Frontend
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: cbrindusan, Assigned: camd)
References
Details
Attachments
(1 file)
|
14.08 KB,
image/png
|
Details |
There is a situation in Treeherder where the "Classification saved for..." would get stuck until the refresh of the page. This happens randomly.
| Reporter | ||
Updated•8 years ago
|
Flags: needinfo?(cdawson)
Summary: "Classification saved for..." stuck until the refresh of the page → "Classification saved for..." banner getting stuck until the refresh of the page
Updated•8 years ago
|
| Assignee | ||
Updated•8 years ago
|
Assignee: nobody → cdawson
Status: NEW → ASSIGNED
Flags: needinfo?(cdawson)
Comment 1•7 years ago
|
||
Cam, can you prioritize this, please? It requires reloads of Treeherder which take some time to download the data for all pushes. Thank you.
| Assignee | ||
Comment 2•7 years ago
|
||
Yes, I will try to get this fixed this week. But you should be able to hit escape to clear any on-screen notifications. I added that feature recently. Does that work to help prevent you from having to reload?
| Assignee | ||
Updated•7 years ago
|
Flags: needinfo?(cdawson)
| Assignee | ||
Comment 3•7 years ago
|
||
I'm not yet able to reproduce this. If anyone does, please check if there's an error message on the console. That might help point to the problem.
| Assignee | ||
Comment 4•7 years ago
|
||
Talked to Cristin in IRC and he said he's not able to reproduce this after yesterday's push. I wonder if the change to class-level functions helped this. Either way, I'm going to back-burner this and perhaps mark it as WFM if we can't reproduce it soon.
Flags: needinfo?(cdawson)
| Reporter | ||
Comment 5•7 years ago
|
||
I was finally able to repro this issue again by re-triggering a job more than 20 times (5 notifications got stuck on the screen).
To repro, use the following range of pushes and retrigger the "dt1" job 25-30 times:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&classifiedState=unclassified&searchStr=os%2Cx%2C10.10%2Copt%2Cmochitests%2Cwith%2Ce10s%2Ctest-macosx64%2Fopt-mochitest-devtools-chrome-e10s-1%2Cm-e10s%28dt1%29&fromchange=4666c210aa93dec761ee8893b0b31fa32283ad3b&tochange=b87408f9197d7e259c9ad5228ad925383352a287
| Assignee | ||
Comment 6•7 years ago
|
||
Cristin: Thanks for the update. I'll try it out. So, when this happens, are you able to hit "esc" to clear them? Just curious if that is broken in this context as well. Though I'll try it myself, too. :)
| Assignee | ||
Comment 7•7 years ago
|
||
I'm able to reproduce with classifying, too. Just classify a ton of jobs. Presumably >25 or so. It must be overloading something. Hitting "esc" DOES clear them, however. Working on a fix.
Comment 8•7 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/4ce36e762eaae334a09bc7bafb954b830b88660c
Bug 1499559 - Fix notifications not auto-expiring (#4420)
| Assignee | ||
Comment 9•7 years ago
|
||
This will be fixed once it's pushed to production.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•