Remove Ukrainian from builds

RESOLVED FIXED in Future

Status

enhancement
RESOLVED FIXED
10 months ago
8 months ago

People

(Reporter: artem, Assigned: frg)

Tracking

unspecified
Future
Dependency tree / graph

SeaMonkey Tracking Flags

(seamonkey2.49esr wontfix, seamonkey2.53 wontfix, seamonkey2.57esr fixed, seamonkey2.60 wontfix, seamonkey2.63 fixed)

Details

Attachments

(1 attachment)

Please remove Ukrainian locale of SeaMonkey from builds.
There was nobody in the team interested to manage localizations for a long time and now it is completely outdated.
I forget which of you handle this now,

rough steps:

* Remove uk from https://dxr.mozilla.org/comm-central/source/comm/suite/locales/all-locales
* Remove uk from https://dxr.mozilla.org/comm-central/source/comm/suite/locales/l10n.toml

* If possible make an explicit update rule from the last uk Nightly to the next en-US nightly so that uk Nightly users get updated to en-US [en-US chosen per IRC chat with a uk l10n lead]
   - Since this is only for Nightly its not a strict requirement, might be able to pull data to see user % of this to help determine necessity.

AFAICT SeaMonkey never shipped uk to non-nightly users so no need to do more complex changes for update verify or similar code.
Flags: needinfo?(iann_bugzilla)
Flags: needinfo?(frgrahl)
Flags: needinfo?(ewong)
Lets take it out of esr60 too. No c-c means no translations for 2.57 too.

ewong source tree should be clear. DidnÄt find anything else. I suspect nothing needed on the builders for it but you might want to check. No working Nightly so no need to move to en-US either.
Assignee: nobody → frgrahl
Status: NEW → ASSIGNED
Flags: needinfo?(iann_bugzilla)
Flags: needinfo?(frgrahl)
Attachment #9017877 - Flags: review?(iann_bugzilla)
Attachment #9017877 - Flags: approval-comm-esr60?
(In reply to Justin Wood (:Callek) from comment #1)
> I forget which of you handle this now,
> 
> rough steps:
> 
> * Remove uk from
> https://dxr.mozilla.org/comm-central/source/comm/suite/locales/all-locales
> * Remove uk from
> https://dxr.mozilla.org/comm-central/source/comm/suite/locales/l10n.toml
> 
> * If possible make an explicit update rule from the last uk Nightly to the
> next en-US nightly so that uk Nightly users get updated to en-US [en-US
> chosen per IRC chat with a uk l10n lead]
>    - Since this is only for Nightly its not a strict requirement, might be
> able to pull data to see user % of this to help determine necessity.
> 
> AFAICT SeaMonkey never shipped uk to non-nightly users so no need to do more
> complex changes for update verify or similar code.

Thanks Callek!  Will make that change.
Flags: needinfo?(ewong)
Comment on attachment 9017877 [details] [diff] [review]
1499654-remove-uk.patch

Review of attachment 9017877 [details] [diff] [review]:
-----------------------------------------------------------------

Lgtm and stealing review. :)
Attachment #9017877 - Flags: review?(iann_bugzilla) → review+
Comment on attachment 9017877 [details] [diff] [review]
1499654-remove-uk.patch

a=me
Attachment #9017877 - Flags: approval-comm-esr60? → approval-comm-esr60+
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/b9ca6e1d8ca9
Remove uk locale from SeaMonkey. r=ewong
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
NI on Pike to remove it from the dashboard.
Flags: needinfo?(l10n)
I guess this is supposed to land on Beta, too?
Flags: needinfo?(frgrahl)
We currently don't care about Beta. SeaMonkey builds but is broken for 3 releases now. No build jobs currently running in beta too. If you really need it there let me know.
Flags: needinfo?(frgrahl)
Yes, please add the change to beta. As long as it's in the configs, I can't disable it on l10n.m.o.
Flags: needinfo?(l10n)
Flags: needinfo?(l10n)
Comment on attachment 9017877 [details] [diff] [review]
1499654-remove-uk.patch

Done. IanN can you set a+ for beta.
https://hg.mozilla.org/releases/comm-beta/rev/bcaa8d88f2815c2a055e576307901ded5e6ae917
Attachment #9017877 - Flags: approval-comm-beta?
Thanks, Ukrainian SeaMonkey de-activated on elmo.
Flags: needinfo?(l10n)
Comment on attachment 9017877 [details] [diff] [review]
1499654-remove-uk.patch

[Triage Comment]
a=me
Attachment #9017877 - Flags: approval-comm-beta? → approval-comm-beta+
Thank you all for resolving it!
How we should remove localization files from the repo?
(In reply to Artem Polivanchuk from comment #15)
> Thank you all for resolving it!
> How we should remove localization files from the repo?

If you want to do it, I would suggest to file a bug in the Ukrainian component, remove the folder from hg and mention that bug in the commit message (so it's easier to find if someone decides to resurrect them). I can do it for you if you prefer.
Ok, I'll do it as you suggest. Thanks :)
Blocks: 1503488
You need to log in before you can comment on or make changes to this bug.