Closed Bug 1499795 Opened 10 months ago Closed 6 months ago

DNS Over HTTPS preferences don't properly respond to being locked

Categories

(Firefox :: Preferences, enhancement, P1)

enhancement

Tracking

()

VERIFIED FIXED
Firefox 67
Tracking Status
firefox64 --- wontfix
firefox65 --- wontfix
firefox66 --- wontfix
firefox67 --- verified

People

(Reporter: mkaply, Assigned: jkt)

References

Details

(Whiteboard: [trr])

Attachments

(1 file)

Because the DNS over HTTPS pref isn't boolean, the checkbox for enabling/disabling DNS over HTTPS isn't properly responding to the locking of the preference.
Whiteboard: [trr]
Assignee: nobody → jkt

To test this I was using variants on the below code stored at: obj-build/dist/bin/distribution/policies.json

{
  "policies": {
    "BlockAboutConfig": false,
    "BlockAboutProfiles": true,
    "BlockAboutAddons": true,
    "DNSOverHTTPS": {
      "Enabled": true,
      "Locked": true
    }
  }
}
Status: NEW → ASSIGNED
Pushed by jkingston@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0f706ba8fc8d
Disabling DoH about:preferences controls when the network.trr.mode pref is locked. r=jaws
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67

Could you please provide some steps to verify this issue just to make sure I'm not missing something?
Thanks.

Flags: needinfo?(jkt)

Emil Ghitta helped me with the steps.
Verified as fixed on Firefox Nightly 67.0a1 (2019-03-19) on Windows 10 x 64 and Ubuntu 16.04 x64 and Mac OS X 10.14.

Status: RESOLVED → VERIFIED
Flags: needinfo?(jkt)
You need to log in before you can comment on or make changes to this bug.